On Mon, Apr 10, 2017 at 06:22:06PM -0700, Laura Abbott wrote:
> Once upon a time, the kernel needed a lot of special handling to
> generate proper debuginfo as the kernel was ahead in technology. These
> days, rpm has improved debuginfo support. The kernel has not kept up
> with this and it's forward looking calls are now out of date. Switch to
> more standard invocations of debuginfo calls.
> ---
> This is a slightly reduced version of the previous patch. It keeps the existing
> behavior by using the standard find-debuginfo.sh call with the proper undefines.
Thanks Laura! Sorry about the previous version.
Acked-by: Don Zickus <dzickus@xxxxxxxxxx>
Mark W.,
Do you have much insight into how the below definitions would interact with
the kernel?
> @@ -395,7 +395,14 @@ BuildRequires: pciutils-devel gettext ncurses-devel
> BuildConflicts: rhbuildsys(DiskFree) < 500Mb
> %if %{with_debuginfo}
> BuildRequires: rpm-build, elfutils
> -%define debuginfo_args --strict-build-id -r
> +# Most of these should be enabled after more investigation
> +%undefine _include_minidebuginfo
> +%undefine _find_debuginfo_dwz_opts
> +%undefine _unique_build_ids
> +%undefine _unique_debug_names
> +%undefine _unique_debug_srcs
> +%global _find_debuginfo_opts -r
> +%global _missing_build_ids_terminate_build 1
> %endif
I am only poking you because it seems like you spent a lot of time cleaning
up some of the rpm macros in the rpm pkg.
Cheers,
Don
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
