On Thu, Nov 10, 2016 at 4:03 PM, Peter Robinson <pbrobinson@xxxxxxxxx> wrote: > On Thu, Nov 10, 2016 at 8:59 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: >> On Thu, 2016-11-10 at 20:28 +0000, Peter Robinson wrote: >>> I agree with Josh, what is it that you're actually trying to achieve here? >> >> What I want to achieve is to make the build a bit more quiet. And I prefer it >> to not do things for no good reason. >> >> But it turns out I can get what I want if we remove the call of "make >> oldnoconfig" during %prep. There really is no need to do that for all config >> files in configs/, as only one of those files will be used for the build. And >> the file that actually will be used during %build will go through "make >> oldnoconfig". So why bother doing that earlier during %prep? > > The reason it's done during prep for all config files is so that > maintainers can do a basic "fedpkg prep" to make sure they haven't > broken anything before pushing it. I do this numerous times a day when > working on kernel stuff. Right. Paul, your changes make some logical sense but they break the workflow of the people that have to maintain the package. That's where most of the pushback is going to come from. josh _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
