On Thu, Nov 10, 2016 at 11:08 AM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> During the %prep phase we run "make listnewconfig" and "make oldnoconfig" for
> all six supported architectures (arm64, arm, i386, powerpc, s390, and x86_64).
> We only care about the set of .configs that is relevant for the current build
> architecture. So skip these two make targets for the other architectures.
>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
NAK on this one.
We used to only run it for the current build architecture. However,
when we did that what wound up happening is that we'd have the new
options configured for that specific architecture (which is always
x86_64 because that is what people use), and it would then fail in
koji on the other architectures because of unset new configs.
So we run it for all arches to make sure we catch all new config
options as they come in.
josh
> ---
> kernel.spec | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel.spec b/kernel.spec
> index f0fe21fef94b..e791d2565efc 100644
> --- a/kernel.spec
> +++ b/kernel.spec
> @@ -1250,6 +1250,9 @@ for i in *.config
> do
> mv $i .config
> Arch=`head -1 .config | cut -b 3-`
> + if [ $Arch != %{hdrarch} ]; then
> + continue
> + fi
> %if %{listnewconfig_fail}
> make ARCH=$Arch listnewconfig | grep -E '^CONFIG_' >.newoptions || true
> if [ -s .newoptions ]; then
> --
> 2.7.4
> _______________________________________________
> kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
