Re: [PATCH] Check configuration files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2016-08-28 at 23:07 -0700, Miguel A. Flores Silverio wrote:
> On Thu, Aug 25, 2016 at 12:08 PM, Laura Abbott <labbott@xxxxxxxxxx>
> wrote:
> > On 08/25/2016 11:35 AM, Paul Bolle wrote:
> > > On Thu, 2016-08-25 at 09:16 -0700, Laura Abbott wrote:
> > > > There should be an option to ignore it though if people don't
> > > > want.
> > > > Miguel, can you add an option similar to listnewconfig_fail?
>  
> Yes! It should be as simple as adding another macro similar to
> listnewconfig_fail.

This made me look into listnewconfig_fail. (I build with that variable
set to zero - because I build vanilla kernel rpms so nopathces is set.)

It turns out we run "make listnewconfig" for no obvious reason if
listnewconfg_fail is set to zero. Ie, the section where "make
listnewconfig" is called should actually read:
    %if %{listnewconfig_fail}
      make ARCH=$Arch listnewconfig | grep -E '^CONFIG_' >.newoptions || true
      if [ -s .newoptions ]; then
        cat .newoptions
        exit 1
      fi
      rm -f .newoptions
    %endif

Perhaps, Miguel, you can look into that too while you're at it.

Thanks,


Paul Bolle
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux