Re: [PATCH] Make GPIO pinctrl for CherryTrail builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 16, 2015 at 9:16 AM, Bastien Nocera <bnocera@xxxxxxxxxx> wrote:
>
>
> ----- Original Message -----
>> On Wed, Dec 16, 2015 at 9:11 AM, Bastien Nocera <bnocera@xxxxxxxxxx> wrote:
>> > From: Bastien Nocera <hadess@xxxxxxxxxx>
>> >
>> > As for the BayTrail one.
>> > ---
>> >  config-x86-generic | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/config-x86-generic b/config-x86-generic
>> > index ee29523..19daf7c 100644
>> > --- a/config-x86-generic
>> > +++ b/config-x86-generic
>> > @@ -527,7 +527,7 @@ CONFIG_PWM_LPSS_PCI=m
>> >  CONFIG_PWM_LPSS_PLATFORM=m
>> >  CONFIG_PINCTRL=y
>> >  CONFIG_PINCTRL_BAYTRAIL=y
>> > -CONFIG_PINCTRL_CHERRYVIEW=m
>> > +CONFIG_PINCTRL_CHERRYVIEW=y
>>
>> Remind me why either of these need to be built in?  It's bloating the
>> kernel for every x86 machine other than cherryview or baytrail.
>
> "bloat". It's needed because our ACPI subsystem still sucks, and can't really

You can put as many quotation marks around it as you want, but it is
still bloat for every non-cherryview machine in existence.  That
happens to be the vast majority of the machines using Fedora.

> handle devices being missing. By building it in, we make sure it's available as
> early as possible, and that probed devices are available when ACPI pokes at them.

Hopefully that's being worked somewhere and we aren't relying on this
somewhat hacky solution long term.  I've applied the patch because the
resource usage is relatively small, but I certainly don't want to make
a habit of building things in because of deficiencies elsewhere in the
stack.

josh
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/kernel@xxxxxxxxxxxxxxxxxxxxxxx



[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux