Re: [PATCH] GFS2: Make rename not save dirent location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message -----
> On Tue, Oct 7, 2014 at 12:15 PM, Bob Peterson <rpeterso@xxxxxxxxxx> wrote:
> > Hi,
> >
> > This patch fixes a regression in the patch "GFS2: Remember directory
> > insert point", commit 2b47dad866d04f14c328f888ba5406057b8c7d33.
> > The problem had to do with the rename function: The function found
> > space for the new dirent, and remembered that location. But then the
> > old dirent was removed, which often moved the eligible location for
> > the renamed dirent. Putting the new dirent at the saved location
> > caused file system corruption.
> >
> > This patch adds a new "save_loc" variable to struct gfs2_diradd.
> > If 1, the dirent location is saved. If 0, the dirent location is not
> > saved and the buffer_head is released as per previous behavior.
> >
> > Signed-off-by: Bob Peterson <rpeterso@xxxxxxxxxx>
> > Signed-off-by: Steven Whitehouse <swhiteho@xxxxxxxxxx>
> 
> Did you mean to send this to the upstream kernel list, or is this
> somehow Fedora specific?
> 
> josh

Hi Josh,

The patch is already in the gfs2 "nmw" tree upstream but it hasn't been
pulled by Linus yet:

http://git.kernel.org/cgit/linux/kernel/git/steve/gfs2-3.0-nmw.git/commit/fs/gfs2?id=19aeb5a65f1a6504fc665466c188241e7393d66f

It is not Fedora specific. Maybe I need to send it elsewhere?
I just want to make sure it gets into the Fedora-20 stable kernel and such.
I've always just posted patches like this upstream and let $MAGIC get
them into Fedora, but in this case, the bug is pretty nasty.

Regards,

Bob Peterson
Red Hat File Systems
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/kernel





[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux