On Tue, Apr 1, 2014 at 1:37 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: > On Tue, 2014-04-01 at 12:50 -0400, Josh Boyer wrote: > >> --- /dev/null >> +++ b/filter-i686.sh >> @@ -0,0 +1,5 @@ >> +#! /bin/bash >> + >> +driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds >> media memstick message mfd mmc mtd nfc ntb pcmcia platform power ssb >> staging uio uwb" >> + >> +singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs iscsi_tcp megaraid >> pmcraid qla1280 9pnet_rdma svcrdma xprtrdma hid-picolcd hid-prodikeys >> hwa-hc hwpoison-inject hid-sensor-hub hid-sensor-magn-3d >> hid-sensor-incl-3d hid-sensor-als.ko > > Just hid-sensor-als here? > >> hid-sensor-gyro-3d hid-sensor-iio-common hid-sensor-accel-3d hid-sensor-trigger hid-sensor-als" > > There's hid-sensor-als again. So just drop hid-sensor-als.ko? > > I don't know how to review this. But I did spot this typo. Yep, I'll fix that. Thanks for spotting it. As for "how to review", basically the *dirs variables are lists of entire directories to move. singlemods are single modules to move. There's not a ton of review other than looking at the resulting builds and making sure the depmod call succeeds without error and fixing the lists if it doesn't. Which reminds me that I need to flip this to fail the build if that depmod call fails after people sign off on things. josh _______________________________________________ kernel mailing list kernel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/kernel
