Re: [PATCH 1/3] [ARM][TEGRA][PAZ00] Add TPS6586x RTC/Regulator as builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 14, 2014 at 8:38 AM, Nicolas Chauvet <kwizart@xxxxxxxxx> wrote:
> This prevent rtc to appear too late on the Toshiba AC100
> déc. 31 19:00:01 localhost kernel: drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
> ...
> déc. 31 19:00:01 localhost kernel: tps6586x-rtc tps6586x-rtc: rtc core: registered tps6586x-rtc as rtc0
>
> The powered rtc is accesseded via i2c so this requires IC2_TEGRA=y
> in order to work

Shouldn't the rtc module have a dependency on I2C and do a
request_module on it?  Building it into the kernel works, but only
because the i2c-tegra module is doing a subsys_initcall instead of
just plain module_init.  Seems somewhat tenuous.

Looking at the i2c-tegra driver, I think it should be OK to built in
as it seems to have the proper device tree matches in place.  I'm
curious if you tested this on any of the other boards that are built
in the multiboard armv7 kernels though.

josh

> ---
>  config-armv7         |    4 ++--
>  config-armv7-generic |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/config-armv7 b/config-armv7
> index c148a67..c3019f7 100644
> --- a/config-armv7
> +++ b/config-armv7
> @@ -508,7 +508,7 @@ CONFIG_TEGRA_IOMMU_GART=y
>  CONFIG_TEGRA_IOMMU_SMMU=y
>  CONFIG_MMC_SDHCI_TEGRA=m
>
> -CONFIG_I2C_TEGRA=m
> +CONFIG_I2C_TEGRA=y
>
>  CONFIG_TEGRA_SYSTEM_DMA=y
>  CONFIG_TEGRA_EMC_SCALING_ENABLE=y
> @@ -549,7 +549,7 @@ CONFIG_NVEC_LEDS=y
>  CONFIG_NVEC_PAZ00=y
>  CONFIG_MFD_TPS6586X=y
>  CONFIG_GPIO_TPS6586X=y
> -CONFIG_RTC_DRV_TPS6586X=m
> +CONFIG_RTC_DRV_TPS6586X=y
>
>  CONFIG_PWM_TEGRA=m
>
> diff --git a/config-armv7-generic b/config-armv7-generic
> index a81ca01..d493212 100644
> --- a/config-armv7-generic
> +++ b/config-armv7-generic
> @@ -461,7 +461,7 @@ CONFIG_REGULATOR_TPS6507X=m
>  CONFIG_REGULATOR_TPS65090=m
>  CONFIG_REGULATOR_TPS65217=m
>  CONFIG_REGULATOR_TPS6524X=m
> -CONFIG_REGULATOR_TPS6586X=m
> +CONFIG_REGULATOR_TPS6586X=y
>  CONFIG_REGULATOR_TPS65910=m
>  CONFIG_REGULATOR_TPS65912=m
>  CONFIG_REGULATOR_TPS80031=m
> --
> 1.7.2.1
>
> _______________________________________________
> kernel mailing list
> kernel@xxxxxxxxxxxxxxxxxxxxxxx
> https://admin.fedoraproject.org/mailman/listinfo/kernel
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/kernel





[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux