Re: Silence advansys build time warning in Fedora's kernel build?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01/23/2014 12:10 PM, Paul Bolle wrote:
Hans,

On Thu, 2014-01-23 at 11:59 +0100, Hans de Goede wrote:
On 01/23/2014 11:46 AM, Paul Bolle wrote:
0) I've tried to get a trivial patch upstream. It silences a build time
warning generated by the advansys driver:
- November 2012: https://lkml.org/lkml/2012/11/5/164 ;
- January 2013: https://lkml.org/lkml/2013/1/29/144 ; and
- January 2014: https://lkml.org/lkml/2014/1/8/569 .

[hans@shalem linux]$ scripts/get_maintainer.pl -f drivers/scsi/advansys.c
Matthew Wilcox <matthew@xxxxxx> (maintainer:ADVANSYS SCSI DRIVER)
"James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx> (maintainer:SCSI SUBSYSTEM)
linux-scsi@xxxxxxxxxxxxxxx (open list:ADVANSYS SCSI DRIVER)
linux-kernel@xxxxxxxxxxxxxxx (open list)

Have you tried sending a direct mail to Matthew and / or James about this?

I see them in the CC field, but not in the To field of these patches.

All three messages were sent to Matthew directly. James got the first
message directly. The second and third were CC-ed to James. linux-scsi
and linux-kernel were always CC-ed.

I think I've done enough to get this trivial patch noted by this
driver's maintainer, and the SCSI people in general, haven't I?

I'm not saying you haven't but in my experience for some low-profile patches,
the fix is to just poke upstream harder. I don't think disabling a Kconfig setting
in Fedora because you cannot get a patch fixing a compiler warning upstream is
a good idea.

Perhaps it would also help if in the next re-send of the patch upstream you
explain in somewhat more detail why compiler warnings are a big problem for
your workflow / use-case.

Regards,

Hans
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/kernel





[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux