On Wed, Jul 10, 2013 at 10:17:22AM -0400, Dave Anderson wrote: > OK, but for those of us who use it, the change that presumably causes this > would be this part of this commit: > Yeah, we have duplicate declarations in crash-driver.patch... I've fixed it now in rawhide. > commit c5a130325f13b219438cb100e2da71a3e31199f3 > Author: Chen Gong <gong.chen@xxxxxxxxxxxxxxx> > Date: Thu Jun 6 15:20:51 2013 -0700 > > ACPI/APEI: Add parameter check before error injection > > When param1 is enabled in EINJ but not assigned with a valid > value, sometimes it will cause the error like below: > > APEI: Can not request [mem 0x7aaa7000-0x7aaa7007] for APEI EINJ Trigger registers > > It is because some firmware will access target address specified in > param1 to trigger the error when injecting memory error. This will > cause resource conflict with regular memory. So It must be removed > from trigger table resources, but incorrect param1/param2 > combination will stop this action. Add extra check to avoid > this kind of error. > > Signed-off-by: Chen Gong <gong.chen@xxxxxxxxxxxxxxx> > Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx> > > diff --git a/kernel/resource.c b/kernel/resource.c > index d738698..77bf11a 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -409,6 +409,7 @@ int __weak page_is_ram(unsigned long pfn) > { > return walk_system_ram_range(pfn, 1, NULL, __is_ram) == 1; > } > +EXPORT_SYMBOL_GPL(page_is_ram); > > void __weak arch_remove_reservations(struct resource *avail) > { > > > where the additional EXPORT_SYMBOL_GPL(page_is_ram) above now makes > it available from both kernel/resource.c and arch/x86/mm/ioremap.c. > Why would that make it an unknown symbol? > > Dave > > _______________________________________________ > kernel mailing list > kernel@xxxxxxxxxxxxxxxxxxxxxxx > https://admin.fedoraproject.org/mailman/listinfo/kernel _______________________________________________ kernel mailing list kernel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/kernel