On 06/14/2013 04:27 PM, Thorsten Leemhuis wrote: > Hi! > > Harald Hoyer wrote on 14.06.2013 16:02: >> On 06/13/2013 09:08 AM, harald@xxxxxxxxxx wrote: >>> >>> This patch changes the version of kernel flavor/variants to end >>> in "+$flavor" instead of ".$flavor". This makes it easier to detect >>> a flavor and a parser can separate it from the architecture. >>> >>> With that change we can correct kernel-install (of systemd) to call >>> new-kernel-package with --package kernel-$flavor, because the $flavor >>> can easily be extracted from the version string. >>> --- >>> >>> After talking to the rpm team, "+" is the only char left as a separator. >>> >>> Kernel compiles and runs: >>> $ uname -r >>> 3.10.0-0.rc5.git0.1.fc20.x86_64+debug >>> $ echo /lib/modules/*debug >>> /lib/modules/3.10.0-0.rc5.git0.1.fc20.x86_64+debug >> >> Any comments? > > I'll bite, even if I'm just a interested party. The + kind of looks ugly > to me. In your initial mail ("Patch for kernel variants/flavors") you wrote Come on... "+" instead of "-" or "." and it suddenly looks ugly to you? Actually, I kind of like it, because it springs right into your eyes :) IMHO, adding ".general" or ".default" actually has the potential for more breakage than changing "." into "+". _______________________________________________ kernel mailing list kernel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/kernel