On Tue, Jun 26, 2012 at 06:28:52PM +0200, Oleg Nesterov wrote:
> On 06/25, Anton Arapov wrote:
> >
> > --- a/include/linux/tracehook.h
> > +++ b/include/linux/tracehook.h
> > @@ -49,6 +49,7 @@
> > #include <linux/sched.h>
> > #include <linux/ptrace.h>
> > #include <linux/security.h>
> > +#include <linux/task_work.h>
> > struct linux_binprm;
> >
> > /*
> > @@ -165,8 +166,10 @@ static inline void tracehook_signal_handler(int sig, siginfo_t *info,
> > */
> > static inline void set_notify_resume(struct task_struct *task)
> > {
> > +#ifdef TIF_NOTIFY_RESUME
> > if (!test_and_set_tsk_thread_flag(task, TIF_NOTIFY_RESUME))
> > kick_process(task);
> > +#endif
> > }
>
> FYI, this change is not exactly correct...
>
> The patch should also remove another "ifdef TIF_NOTIFY_RESUME" above,
> see the original patch: http://marc.info/?l=linux-kernel&m=133487746527839
>
> This part was lost because the patch was routed via Al Viro's tree,
> and that ifdef was already killed by 1227dd77
>
> However, I guess we do not care, fedora kernel doesn't run on
> !TIF_NOTIFY_RESUME machines.
>
> So I think the patch is fine for F16/F17
Applied in Fedora git now. Thanks to Anton for the backport and to you
for the ACK.
josh
_______________________________________________
kernel mailing list
kernel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/kernel
