Re: [New Driver]: usbvideo2 webcam core + pac207 driver using it.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pete Zaitcev wrote:
#define CLIP(color) (unsigned char)(((color)>0xFF)?0xff:(((color)<0)?0:(color)))
Add a comment about what this is doing?  Could you just do it as a
static function instead?

The macro itself is too trivial to be commented, IMHO, but I have
to ask just what it is doing there. It is only applied to
precomputed values from pac207_decompress_table, as far as I see.
So, they cannot be out of range. Or can they?


Its being applied to the addition of a value read from the sensor and a precomputed value from the pac207_decompress_table, and the total of these can be out of range.

Regards,

Hans

_______________________________________________
Fedora-kernel-list mailing list
Fedora-kernel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-kernel-list

[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux