Re: [RFC PATCH] lirc IR receiver drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Sandeen wrote:
Jarod Wilson wrote:
Hey all,

So... As I've mentioned on various forums here and there in the recent past, I'd really like to see fedora carry the lirc drivers (http://www.lirc.org/) in-kernel, and help push them into the upstream kernel. I finally got around to doing something significant about it this evening. The link below is the completion of my first attempt at a patch tailored for upstream, based partially on work done by Mario Limonciello for Ubuntu (cc'd).

http://people.redhat.com/jwilson/lirc/linux-2.6-lirc.patch

Cool, I tossed a few build-related fixes (warnings, deprecated
interfaces/flags, etc..) on top of this up at

http://people.redhat.com/esandeen/lirc/

Very nice. Gah, at least one of those fixes some things I screwed up merging in the latest bits from cvs...

(There's also usb stuff going on I don't understand in the commandir
driver :) but with the warning about the callback it will probably
explode when run.)

Hrm, that's not so good... I was thinking of seeing if I could find one somewhere for cheap, but ouch, those things look pricey...

http://www.commandir.com/order/

Also given that each subdir under drivers/input/lirc generally has just
one .c file, I'd probably flatten it out, and drop everything into
drivers/input/lirc/*.c

Yeah, that idea crossed my mind too after I'd sent the mail off before drifting off to sleep. I'll do that for the next rendition.

Also in Kconfig, INPUT_LIRC and LIRC_DEV seem a little redundant -
perhaps each individual driver should just do "select LIRC_DEV" rather
than "depends on?" and remove the prompt for LIRC_DEV?

Sounds like a good idea to me.

--
Jarod Wilson
jwilson@xxxxxxxxxx

_______________________________________________
Fedora-kernel-list mailing list
Fedora-kernel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-kernel-list

[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux