On Wed, Sep 11, 2024 at 11:16 PM Kevin Fenzi <kevin@xxxxxxxxx> wrote: > > Our containers are built in koji via the kiwi plugins. > At first, koji included the buildroot repo in building these, but this > has a unintended problem: the rpms in the buildroot are not signed, so > this causes the packages in the produced containers to not be signed. ;( > > See: > https://bugzilla.redhat.com/show_bug.cgi?id=2270397 > > So, to fix this we had made a koji patch to not use the buildroot repo > when making kiwi containers, it was then tweaked and upstreamed, so we > dropped out patch and started using the upstream version, but > unfortunately it's not working for us because upstream there's a check > to use the old behavior for older koji versions (to avoid changing > people in a minor release). > > So, I would like to apply this: > > diff --git a/plugins/hub/kiwi.py b/plugins/hub/kiwi.py > index 4aeb1048..b9ad0c6a 100644 > --- a/plugins/hub/kiwi.py > +++ b/plugins/hub/kiwi.py > @@ -17,7 +17,7 @@ koji.tasks.LEGACY_SIGNATURES['createKiwiImage'] = [ > @export > def kiwiBuild(target, arches, desc_url, desc_path, optional_arches=None, profile=None, > scratch=False, priority=None, make_prep=False, repos=None, release=None, > - type=None, type_attr=None, result_bundle_name_format=None, use_buildroot_repo=True, > + type=None, type_attr=None, result_bundle_name_format=None, use_buildroot_repo=False, > version=None, repo_releasever=None): > context.session.assertPerm('image') > for i in [desc_url, desc_path, profile, version, release, repo_releasever]: > > to our f40-koji package and update the hubs. > > +1s? > +1 -- 真実はいつも一つ！/ Always, there's only one truth! -- _______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
