Re: [PATCH] s3-mirror: fix missing trailing /

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



LGTM +1

On Mon, Mar 16, 2020 at 1:28 PM Stephen John Smoogen <smooge@xxxxxxxxx> wrote:
>
>
> This is an FBR and I +1 it
>
> On Mon, 16 Mar 2020 at 13:01, Kevin Fenzi <kevin@xxxxxxxxx> wrote:
>>
>> This is causing f31 updates to not be synced. The cron job reports:
>>
>> Subject: Cron <s3-mirror@mm-backend01> /usr/local/bin/lock-wrapper s3sync-updates-current "/usr/local/bin/s3-sync-path.sh /pub/fedora/linux/updates/31/Everything/x86_64/os" 2>&1 |
>>         /usr/local/bin/nag-once s3-updates-current.sh 1d 2>&1
>>
>> Syntax: /usr/local/bin/s3-sync-path.sh /pub/path/to/sync/
>> NOTE! Path must end with a trailing /
>>
>> Signed-off-by: Kevin Fenzi <kevin@xxxxxxxxx>
>> ---
>>  roles/s3-mirror/tasks/main.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/roles/s3-mirror/tasks/main.yml b/roles/s3-mirror/tasks/main.yml
>> index 5da7a02..395679b 100644
>> --- a/roles/s3-mirror/tasks/main.yml
>> +++ b/roles/s3-mirror/tasks/main.yml
>> @@ -69,7 +69,7 @@
>>
>>  - name: s3sync cron - updates for current
>>    cron: name="s3sync-updates-current" minute="0" hour="3,9,15,21" user="s3-mirror"
>> -        job='/usr/local/bin/lock-wrapper s3sync-updates-current "/usr/local/bin/s3-sync-path.sh /pub/fedora/linux/updates/{{ FedoraCycleNumber|int }}/Everything/x86_64/os" 2>&1 | /usr/local/bin/nag-once s3-updates-current.sh 1d 2>&1'
>> +        job='/usr/local/bin/lock-wrapper s3sync-updates-current "/usr/local/bin/s3-sync-path.sh /pub/fedora/linux/updates/{{ FedoraCycleNumber|int }}/Everything/x86_64/os/" 2>&1 | /usr/local/bin/nag-once s3-updates-current.sh 1d 2>&1'
>>          cron_file=s3-updates-current.sh
>>    when: env != 'staging' and inventory_hostname.startswith('mm-backend01.')
>>    tags:
>> --
>> 1.8.3.1
>> _______________________________________________
>> infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
>> To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
>> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
>
>
>
> --
> Stephen J Smoogen.
>
> _______________________________________________
> infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux