ansible-report git hook design

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

Today jlanda, austinpowered and mizdebsk discussed about ticket https://pagure.io/fedora-infrastructure/issue/8157 in #fedora-admin and came up with a few questions on how to implement that solution that I think would be nice to share with the wider group.

There are basically 2 possibility :

1 - We run ansible-report as a pre-commit hook
This means that ansible-report will be run locally before a contributor commit a change. This is not ideal since our contributor are running all kind systems (rhel, fedora, windows ?) so having something that work well for everyone will not be simple. Also this forces our contributors to install ansible-report locally.

2 - We run ansible-report as a pre-receive hook
This means that ansible-report is run on batcave01, but we cannot run ansible-report just on a commit, we need to run the tool against the full repository every time. That involve making a clone of the repo applying the changes in the incoming commit, then run ansible-report on that repository.

This has also a few disadvantages, first we first need to clear all the errors reported by ansible-report in our repo before we enable the hook otherwise all commits will be rejected. It will also slows down every pushes (time to clone, apply patch, run the tool).

Do people have other ideas ? Is this change worth the trouble ?

Thanks

_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux