Hi,
I created the tags as module-epel8-build and module-epel8-playground-build just to be consistent with the naming, so you need to change the config for koji_tag part.
And may be also change the "stream" in the yaml file to epel8 and epel8-playground and change the name of the platform to platform-epel8 and platform-epel8-playground, again just for consistency.
Other than that, its LGTM.
On Thu, Oct 24, 2019 at 3:43 PM Merlin Mathesius <mmathesi@xxxxxxxxxx> wrote:
Now that the build tags have been created (thanks, Mohan!), we should be ready to add the virtual platform module definitions for EPEL-8 to Fedora staging MBS.I have attached a revised patch that includes both the el8 and el8-playground definitions in a single patch file. Aside from the combined patch, the only difference from the previous separate patches is the addition of the 'default_modules_scm_url' and 'use_default_modules' settings to enable ursa prime.Thanks.Merlin_______________________________________________On Wed, Oct 2, 2019 at 5:07 PM Merlin Mathesius <mmathesi@xxxxxxxxxx> wrote:On Wed, Oct 2, 2019 at 12:41 PM Matt Prahl <mprahl@xxxxxxxxxx> wrote:Hi Merlin,I can't think of anything that you need to do before merging and deploying them as long as the Koji tags mentioned in the modulemd files are all set.Of course. We need the module-el8-build and module-el8-playground-build tags. I just created https://pagure.io/releng/issue/8865 for that.Thanks, Matt!On Wed, Oct 2, 2019 at 12:12 PM Merlin Mathesius <mmathesi@xxxxxxxxxx> wrote:Hi, Matt, Jan,Could one of you provide some input here?We're looking to add the virtual platform module definitions for EPEL-8 to Fedora staging MBS. Is there anything specific that needs to happen before merging and deploying them?If you'd like to review the definitions, the patches are re-attached to this message so you don't need to go digging.MerlinOn Tue, Oct 1, 2019 at 11:43 AM Kevin Fenzi <kevin@xxxxxxxxx> wrote:On Mon, Sep 30, 2019 at 02:14:14PM -0500, Merlin Mathesius wrote:
> Hi, all,
>
> Since folks seem to be happy with the el8 platform virtual module
> definitions, can they be merged and deployed to staging--or does something
> else need to happen first? (Of course, any module builds based on
> platform:el8* won't be usable until there are corresponding pungi configs.)
I'm not entirely sure. :)
Can we ask some of the mbs folks what all is needed here?
kevin
_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
--Matt Prahl
Senior Software Engineer, PnT DevOps
Westford, MA
mprahl@xxxxxxxxxx
M: 802-999-0972 IM: mprahl
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
