On Fri, Oct 11, 2019 at 03:41:28PM +0200, Aurelien Bompard wrote:
> Hey folks,
> Last Monday, before the freeze, we updated Robosignatory in prod with a
> few new features, some of which could not be tested in staging as
> thoroughly as we wanted to. As a result, the version currently in prod has
> issues with the CoreOS artifacts. We've worked on that and our tests in
> staging are now entirely successful, that why I'm asking for a freeze
> break to update robosignatory to the latest code (0.6.5) and make some
> adjustments to the configuration file in ansible (patch attached).
> What say you?
> Thanks,
> Aurélien
> diff --git a/roles/robosignatory/templates/robosignatory.toml.j2 b/roles/robosignatory/templates/robosignatory.toml.j2
> index dd2ca2578..61a022289 100644
> --- a/roles/robosignatory/templates/robosignatory.toml.j2
> +++ b/roles/robosignatory/templates/robosignatory.toml.j2
> @@ -309,148 +309,153 @@ handlers = ["console"]
> [consumer_config.ostree_refs]
> [consumer_config.ostree_refs."fedora/rawhide/x86_64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-32"
> + key = "{{ (env == 'production')|ternary('fedora-32', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/rawhide/aarch64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-32"
> + key = "{{ (env == 'production')|ternary('fedora-32', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/rawhide/armhfp/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-32"
> + key = "{{ (env == 'production')|ternary('fedora-32', 'testkey') }}"
> +
> [consumer_config.ostree_refs."fedora/devel/x86_64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/devel/aarch64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/devel/armhfp/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> +
> [consumer_config.ostree_refs."fedora/stable/x86_64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-iot-2019"
> + key = "{{ (env == 'production')|ternary('fedora-iot-2019', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/stable/aarch64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-iot-2019"
> + key = "{{ (env == 'production')|ternary('fedora-iot-2019', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/stable/armhfp/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-iot-2019"
> + key = "{{ (env == 'production')|ternary('fedora-iot-2019', 'testkey') }}"
> +
> [consumer_config.ostree_refs."fedora/31/x86_64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/aarch64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/armhfp/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> +
> [consumer_config.ostree_refs."fedora/30/x86_64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-30"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/30/aarch64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-30"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/30/armhfp/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-30"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
> +
> [consumer_config.ostree_refs."fedora/29/x86_64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/aarch64/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/armhfp/iot"]
> directory = "/mnt/fedora_koji/koji/compose/iot/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
>
> [consumer_config.ostree_refs."fedora/29/x86_64/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/ppc64le/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/aarch64/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/x86_64/updates/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/ppc64le/updates/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/aarch64/updates/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/x86_64/testing/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/ppc64le/testing/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/aarch64/testing/atomic-host"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/x86_64/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/x86_64/updates/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/29/x86_64/testing/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-29"
> + key = "{{ (env == 'production')|ternary('fedora-29', 'testkey') }}"
>
> [consumer_config.ostree_refs."fedora/30/x86_64/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-30"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/30/x86_64/updates/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-30"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/30/x86_64/testing/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-30"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
>
> [consumer_config.ostree_refs."fedora/31/x86_64/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/aarch64/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/ppc64le/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/x86_64/updates/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/x86_64/testing/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/aarch64/updates/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/aarch64/testing/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/ppc64le/updates/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/31/ppc64le/testing/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-31"
> + key = "{{ (env == 'production')|ternary('fedora-31', 'testkey') }}"
>
> [consumer_config.ostree_refs."fedora/rawhide/aarch64/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-32"
> + key = "{{ (env == 'production')|ternary('fedora-32', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/rawhide/ppc64le/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-32"
> + key = "{{ (env == 'production')|ternary('fedora-32', 'testkey') }}"
> [consumer_config.ostree_refs."fedora/rawhide/x86_64/silverblue"]
> directory = "/mnt/fedora_koji/koji/compose/ostree/repo/"
> - key = "fedora-32"
> + key = "{{ (env == 'production')|ternary('fedora-32', 'testkey') }}"
>
>
> [consumer_config.coreos]
> bucket = "fcos-builds"
> - key = "coreos"
> + key = "{{ (env == 'production')|ternary('fedora-30', 'testkey') }}"
>
> [consumer_config.coreos.aws]
> access_key = "{{ fcos_builds_releng_aws_access_id }}"
+1 for the change in ansible.
Do you have a diff for the new releases?
Thanks!
Pierre
_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
