Hi, Pierre-YvesChibon wrote: > [distgit/pagure] Drop --autoreload from our systemd service file I noticed a few recent commits using this bracket prefix style and I wanted to give a heads-up about how this can cause problems, in case it's not well-known. (If I've mentioned it before, please forgive my memory lapse.) Using brackets to prefix the commit message will cause grief for any patches which are applied via 'git am', as the contents within the brackets will be stripped. Even after the ansible repo is available via pagure, there are likely still times when someone will attach a patch to a bug or send it with git send-email. If this [prefix/area] convention is more widely adopted in the ansible repo, it's worth keeping in mind the potential for surprise (and subtle loss of commit message details) it will likely cause down the road. The prefix stripping can be avoided by passing the '--keep-non-patch' option to git am. However, there's no config variable to allow that to be easily set per repo, so it'd be very easy to forget. This has been discussed on the git list in the past. One of the more recent discussions was from 2015: https://public-inbox.org/git/5655D3DA.1050403@xxxxxxxxxxxxxxxxxxxxxxxxx/T/#u I had a recent bug report filed about this as well: https://bugzilla.redhat.com/show_bug.cgi?id=1671640 (as evidence that it surprises others still). Hope this is helpful, -- Todd
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
