On 10/02/2018 03:42 AM, David Shier wrote: > The git tagger references were not, in fact, missed. I saw those, and > decided to ask about them as they did n't look related to me. Nirik > indicated they were something else and needed to reamain, so I left them. Yeah, there were some that didn't matter. :) There were a few stragglers I fixed up after applying your patch. Thanks! I agree it would be good to have nicer commit comment and split it into tagger/statscache commits, but just something to ponder, I applied it. Thanks again for working on this. :) kevin -- > > Am Di, 2. Okt, 2018 um 10:15 A. M. schrieb Mikolaj Izdebski > <mizdebsk@xxxxxxxxxx>: >> On 10/02/2018 02:22 AM, David Shier wrote: >>> All/sysadmin-main - >>> >>> Could someone please review the attached patch file for the removal of >>> tagger and statscache from the ansible repos/proxy lists/ etc.? I was >>> going to attach to issue, but pagure is only letting me do pictures, >>> and >>> this one is large and gnarly as a picture. >> >> 1. Commit subject is way too long and not well formed. There are many >> guidelines on writing commit messages, eg. [1] >> 2. Ideally there should be one service removed per commit, not both in a >> single commit >> 3. You missed multiple references to tagger, see "git grep tagger" >> >> [1] https://chris.beams.io/posts/git-commit/ >> >>> >>> Thanks, >>> >>> Dave Shier/odin >>> >>> >>> >>> _______________________________________________ >>> infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx >>> To unsubscribe send an email to >>> infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx >>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html >>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >>> List Archives: >>> https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx >>> >>> >> >> -- >> Mikolaj Izdebski >> Senior Software Engineer, Red Hat >> IRC: mizdebsk >> _______________________________________________ >> infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx >> To unsubscribe send an email to >> infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx >> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: >> https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx >> > > > > _______________________________________________ > infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx >
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
