FBR: Fix mediawiki page creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi all,

Can I get +1s for the underneath patch to fix mediawiki not calling their own API correctly?
This breaks creating new pages on the wiki (and I should've fixed it way earlier, but forgot).

- From caa8183ffa572ee6ded823e3d1e895d1dcc6a466 Mon Sep 17 00:00:00 2001
From: Patrick Uiterwijk <patrick@xxxxxxxxxxxxxx>
Date: Fri, 31 Aug 2018 19:31:58 +0200
Subject: [PATCH] Fix creating of new wiki pages

This breaks because mediawiki doesn't follow their own documented API[1] and doesn't pass
a base revision ID when creating new pages.

Signed-off-by: Patrick Uiterwijk <patrick@xxxxxxxxxxxxxx>

[1]: https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
- ---
 roles/mediawiki/files/fedmsg-emit.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/roles/mediawiki/files/fedmsg-emit.php b/roles/mediawiki/files/fedmsg-emit.php
index c62bd3ee7..846d28e8a 100644
- --- a/roles/mediawiki/files/fedmsg-emit.php
+++ b/roles/mediawiki/files/fedmsg-emit.php
@@ -205,7 +205,7 @@ function article_save(
   &$flags,
   $revision,
   &$status,
- -  $baseRevId,
+  $baseRevId=0,
   $undidRevId
 ) {
 
- -- 
2.17.1

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJbiXwnAAoJEIZXmA2atR5Qr7AQAKmSRzW5OOCmeA1PkVZefxmR
prWeM6t0CoDcr5Oo6Tsg+fmbFn0LBgkz6qV/PtBMtVT0/roK3HQ1h3pXgoq1sH3Q
JB2BTrE/QiEfvCnzQ7LHoJhY2MNDv7hTcEzZyxglhL6I/a+8I5e6Lb0b5I4PZFKe
e2FjGW0bmJk4XFqClI6ZTr2ahvIfiBeM02MEEybZT04avk6h1E4s0oyl7kvZvS1h
L8kJHLWCT6Xan8bv+scwJT0jPhvyQId4rs3X/ENufn6vFiKhGOv1LVY8Yh3RIoTb
z6KAdTuhXVv6aurhixbrBnaJthvVCwfX2A4rhlh6ouF2bBNBPZJLV3R/ZAUdM3KN
9VNytpwlINh2VQyQ2A7O1VqTPRZaI16fKDNNIyHI0YaG0iLnDUFG1PwqocE2QODN
BdaORmLv5KzeIBBisehrVWkT4N8iY6PhyGAdsUrnGtAiduro+obBTO2tGt/vtagA
rjfiJHG5bPTLWXlNo3GZJIfXGsJq0sOnIwX2qJyYwxdP+MHOiYZQMe1Q6aOI/Gr3
wKxsWnlpIxNtK+sft7qtHyxosFDZSMhI2rakxaVJAk/PFNikEMRvXZiwG98F7FrJ
TS77i+Ij6pSf44ywbuCvLxKTd4k39myplhlKNj/d0SJRI/RAMg4Qy2iqWegTsuRm
/05MNRNvHMW4DqW+VAQs
=NZMI
-----END PGP SIGNATURE-----
_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux