Re: [PATCH] OSTree: Force to create new ostree commit during updates compose run

[Sinny Kumari <ksinny@xxxxxxxxx>]

On Fri, Jun 29, 2018 at 9:48 PM, Dusty Mabe <dusty@xxxxxxxxxxxxx> wrote:

On 06/29/2018 11:14 AM, Sinny Kumari wrote:
> This patch (available in email attachment) is to create new ostree
> commit when there is no content changes since last commit during
> updates compose run. By passing force_new_commit as True, pungi
> runs rpm-ostree command with option --force-nocache .
>
> More details are in releng ticket - https://pagure.io/releng/issue/7585
>
> Thanks,
> Sinny

Thanks Sinny. Can I ask for one change? We actually want "force_new_commit"
only for Atomic Host. For Atomic Workstation/Silverblue we actually don't
want "force_new_commit" because we don't do any formal releases (i.e. 2
week releases) for them and "force_new_commit" actually causes them to get
empty updates.

WDYT?

Yes, makes sense, updated the patch .

Can you please commit this patch to ansible repo and run the required playbook?

Also for my info, it will be nice if you can let me know what playbook you

exactly ran.

--

http://sinny.io/

From 20139bacf6eb1ee72188fd85f5471654fa78b869 Mon Sep 17 00:00:00 2001
From: Sinny Kumari <sinny@xxxxxxxxxx>
Date: Fri, 29 Jun 2018 20:28:21 +0530
Subject: [PATCH] Force to create new ostree commit during updates compose run

Create new ostree commit when there is no content
changes since last commit.

Related - https://pagure.io/releng/issue/7585

Signed-off-by: Sinny Kumari <sinny@xxxxxxxxxx>
---
 roles/bodhi2/backend/templates/pungi.rpm.conf.j2 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/roles/bodhi2/backend/templates/pungi.rpm.conf.j2 b/roles/bodhi2/backend/templates/pungi.rpm.conf.j2
index 631e07af7..a401b8a3c 100644
--- a/roles/bodhi2/backend/templates/pungi.rpm.conf.j2
+++ b/roles/bodhi2/backend/templates/pungi.rpm.conf.j2
@@ -118,6 +118,7 @@ ostree = {
             [% if release.version_int >= 28 %]
                 "version": "!VERSION_FROM_VERSION_DATE_RESPIN",
             [% endif %]
+            "force_new_commit": True
             "treefile": "fedora-atomic-host-updates-[[ request.name ]].json",
             "config_url": "https://pagure.io/fedora-atomic.git";,
             "config_branch": "f[[ release.version ]]",
-- 
2.14.4

_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx/message/V4RSQXRGGRREGAR6F7EIGIKHTYH4IE2M/