On Mon, Apr 23, 2018 at 12:53:13PM -0400, Stephen John Smoogen wrote: > +1 with Kevin's additions. > On 23 April 2018 at 11:40, Kevin Fenzi <kevin@xxxxxxxxx> wrote: > > On 04/23/2018 02:40 AM, Pierre-Yves Chibon wrote: > >> Good Morning Everyone, > >> > >> I re-wrote last week the script fixing the git hooks in dist-git, but its work > >> is getting overridden by the old script running in a cron (that Kevin fixed this > >> week-end). > >> > >> So I would like to replace the cron running the old script with a cron running > >> the new script: > >> > >> Here is the diff: > >> > >> diff --git a/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml b/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml > >> index d357a7d83..bea193af1 100644 > >> --- a/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml > >> +++ b/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml > >> @@ -8,7 +8,7 @@ > >> minute=10 > >> hour="0,12" > >> user=pagure > >> - job="/usr/local/bin/git-check-perms /srv/git/repositories --check=fedmsg-hook -f" > >> + job="/usr/local/bin/distgit_check_hook.py" > >> tags: > >> - git > >> - gitolite > >> > >> > >> Note, we could make this run more often as it runs in a few minutes (the forks > >> being the slowest namespace, the other namespace run under a minute). > >> > >> Thoughts? > > > > +1 to this, but also as we discussed on irc we should get pagure to make > > the repos the way we want them to start with. ;) But that can come in > > with the next pagure version and this fix will make the script much nicer. > > > > Perhaps we should move it to every 15min until we get the pagure change > > in and then back it off to 1 or 2 times a day. Applied, but I went with running it every 30 minutes. It will currently send us an email every time it runs, I'll disable that once we've confirmed it runs as desired :) Pierre _______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
