On Wed, Oct 18, 2017 at 12:45:14PM -0400, Ralph Bean wrote:
> Karsten Hopp reported an issue with the MBS that his module builds of
> modules/krb5 and modules/udisks2 failed, because the MBS failed to tag
> them into f27-modular-updates-candidate at the end of the build. The
> module names weren't in the pkg list.
>
> I've added them directly to get him going again, but the root is an
> issue in the pkg list sync script. Here's a patch that should make it
> work going forwards.
>
> Any +1'd for the following fix? (Tested by hand against the udisks2
> and krb5 modules. I also checked that the patch doesn't accidentally
> add the krb5 package to the list for f27 proper, which would be
> wrong.)
>
> diff --git a/roles/bodhi2/backend/templates/owner-sync-pagure.j2 b/roles/bodhi2/backend/templates/owner-sync-pagure.j2
> index 6131b13..b3400bf 100755
> --- a/roles/bodhi2/backend/templates/owner-sync-pagure.j2
> +++ b/roles/bodhi2/backend/templates/owner-sync-pagure.j2
> @@ -401,9 +401,13 @@ if __name__ == '__main__':
> namespace = info['namespace']
> pkgs = []
> for pkg, branches in namespace_to_projects[namespace].items():
> - # The tag and branch names are the same for "old-style" branches
> if info['branch'] in branches or tag == ('f' + RAWHIDE):
> + # The tag and branch names are the same for "old-style" branches
> pkgs.append(pkg)
> + elif namespace == 'modules':
> + # Add modules to f27-modular-updates even if their only branch is '2.4'
> + pkgs.append(pkg)
> +
> # This is a special project, not in dist-git, but which needs to be in
> # the package list.
> if namespace == 'rpms':
+1 for me as well,
Pierre
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
