Good Morning Everyone,
Looking into fixing the current git hook situation on dist-git I came accross
the following architecture and I would like to discuss it with you.
Each repo contains:
- post-receive pointing to /usr/share/git-core/post-receive-chained
- a folder post-receive-chained.d containing:
- post-receive-alternativearch -> /usr/share/git-core/post-receive-alternativearch
- post-receive-email -> /usr/share/git-core/mail-hooks/gnome-post-receive-email
- post-receive-fedmsg -> /usr/share/git-core/post-receive-fedmsg
And /usr/share/git-core/post-receive-chained contains:
pee \
$GIT_DIR/hooks/post-receive-chained.d/post-receive-fedmsg \
$GIT_DIR/hooks/post-receive-chained.d/post-receive-alternativearch
So each git repo contains symlinks to the different git hooks, but there is no
need for them.
I would propose the following changes:
- Drop post-receive-chained.d entirely from each and every dist-git repo
- Replace /usr/share/git-core/post-receive-chained to be:
pee \
/usr/share/git-core/post-receive-fedmsg \
/usr/share/git-core/post-receive-alternativearch
Adjust the script in ansible in roles/git/checks/files/check-perms.py to
implement these changes.
Bonus, adding/removing hooks would then just become a matter of updating
roles/git/hooks/files/post-receive-chained in ansible.
So we could just add the pagure hooks:
/usr/lib/python2.7/site-packages/pagure/hooks/files/default_hook.py
/usr/lib/python2.7/site-packages/pagure/hooks/files/pagure_hook.py
to it to solve both the lack of logging of commits activity and to add support
for Merges/Fixes/Relates keywords in commit messages.
Finally it looks like the check-perms.py script isn't being run, that may be my
fault (I might have remove the script/cron when cleaning up after deploying
pagure).
What do you think? I know we are in freeze but this shouldn't impact directly
anything release-related. Worth trying now or should it wait some more?
Thanks,
Pierre
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
