[Freeze Break Request] Bodhi: Don't allow Karma to set request to None

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Howdy partners,

Bodhi 2.2.0 introduced a new feature that allowed updates to not
autopush, but to still have karma thresholds. Once the update reaches
the karma threshold when autopush is off, the submitter will be offered
the "push to stable" button.

There's a bug in this code that results in Karma comments explicitly
setting the update request to None[0]. This results in popular updates
that use this feature getting stuck in testing, as every time the
submitter clicks push to stable there's a race between release
engineering pushing the update vs. any helpful tester giving karma to
the update (which will set the request back to None).

I'd like to make one more 2.2 series update for Bodhi to resolve this
issue. The patch[1] is quite small, and is really only deleting a
single line of code from production. The rest of the patch is adjusting
tests.

So what say you, yay or nay?


[0] https://github.com/fedora-infra/bodhi/issues/989
[1] https://github.com/fedora-infra/bodhi/pull/992

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux