Re: ansible playbooks git module usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 07 Jul 2016 02:19:14 -0000
"Will Thames" <willthames@xxxxxxxxxxxxxxxxx> wrote:

> > So, further investigation shows that the ansible 2.1 git module is
> > just broken here. ;) 
> > 
> > I added a reproducer to:
> > 
> > https://github.com/ansible/ansible-modules-core/issues/1509  
> 
> As you'll know from my updates to 1509, that was actually a different
> bug - your bug only manifests in check mode - you were hitting 3024,
> which is fixed with 3025. I'm hoping it can go out with Ansible 2.1.1
> - but if you're willing to use an unreleased stable branch, the fix
> is in the stable-2.1 branch (the fix was merged the commit after
> 2.1.1 RC1 was created)

Ah ha. Excellent. Thanks for digging into that. :) 
> 
> > Of course this needs fixing, but even so, the underlying question
> > still remains (because even after this is fixed, it will show
> > changes when there are changes in the git repos unless we pin to a
> > SHA1).   
> 
> Yes, I still think that pinning to SHA1 (or a tag, if you trust that
> tags won't be force updated) should be the ultimate goal. 

Yep. 

kevin

Attachment: pgpud8FqrOsG0.pgp
Description: OpenPGP digital signature

_______________________________________________
infrastructure mailing list
infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux