Re: Freeze break request: API break request: FAS to not return inactive accounts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 07, 2016 at 02:43:57PM +0000, Patrick Uiterwijk wrote:
> Hi,
> 
> Since we currently have to deal with a lot of spam accounts, it would
> be very useful for our
> systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
> 
> I have just merged a patch for FAS2 to not return inactive accounts by
> default, and I would
> like +1s to push this to production.
> 
> The patch is at https://github.com/fedora-infra/fas/pull/161.
> 
> Do note that this patch does break the FAS2 API in that it suddenly
> stops returning inactive users.
> Please take this into consideration when sending a +1/-1.

Based on the discussion we had here, idea:
  What about inverting the change, keep the behavior the same except and add a
  filter to restrict the user returned to a specified status?

So something like:
  https://admin.stg.fedoraproject.org/accounts/user/list/a*?status=active

This should keep the current behavior the same while allowing those who want to
restrict the list of users to do so.


Thoughts?

Pierre
_______________________________________________
infrastructure mailing list
infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux