2016-03-15 16:19 GMT+01:00 Ralph Bean <rbean@xxxxxxxxxx>:
On Mon, Mar 14, 2016 at 12:22:29PM +0100, Robert Mayr wrote:
> Ok this is for staging websites, but it's a change in ansible and we change
> some pre_tasks, so I ask for +1s to be sure.
>
> Staging websites should not redirect prerelease pages, but show them
> normally (while production must still redirect them to the main page). We
> are just before readiness and should at least test them out.
> I'd comment out the rules for staging as in the diff below, if we need to
> drop also the config files on the proxies, I attach a diff also for
> playbooks/groups/proxies.yml.
> Thanks.
+1 to the idea. However, I think I found a bug:
> diff --git a/playbooks/groups/proxies.yml b/playbooks/groups/proxies.yml
> index 90d5001..1b46198 100644
> --- a/playbooks/groups/proxies.yml
> +++ b/playbooks/groups/proxies.yml
> @@ -74,17 +74,33 @@
> # When we have a prerelease we also need to drop the
> # config files.
>
> - - name: Remove prerelease-to-final-spins
> - file: path=/etc/httpd/conf.d/spins.fedoraproject.org/prerelease-to-final-spins.conf state=absent
> + - name: Remove prerelease-to-final-spins-1
> + file: path=/etc/httpd/conf.d/spins.fedoraproject.org/prerelease-to-final-spins-1.conf state=absent
> + when: env == 'staging'
Look in /etc/httpd/conf.d/blah.fp.o/ on the proxy01.stg node and see
that the file name you're trying to remove here has the role name
appended to it.
So, it's not
prerelease-to-final-spins.conf
but instead is:
prerelease-to-final-spins-redirectmatch.conf
Longer term, it is kind of annoying that when we comment out one of
those roles, we have to go back and add pre_tasks to clean up.
Perhaps we should add a state=absent argument to the role itself so
that it knows how to clean itself up. (Let's save that until after
freeze.)
_______________________________________________
infrastructure mailing list
infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
Thank you, fixed and pushed.
Robert Mayr
(robyduck)
(robyduck)
_______________________________________________ infrastructure mailing list infrastructure@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
