2016-03-14 22:08 GMT+01:00 Kevin Fenzi <kevin@xxxxxxxxx>:
On Mon, 14 Mar 2016 12:22:29 +0100
Robert Mayr <robyduck@xxxxxxxxxxxxxxxxx> wrote:
> Ok this is for staging websites, but it's a change in ansible and we
> change some pre_tasks, so I ask for +1s to be sure.
I don't see the pre_tasks listed?
Thats where we removed the old redirects last time... as long as they
have a staging conditional it should be ok.
> Staging websites should not redirect prerelease pages, but show them
> normally (while production must still redirect them to the main
> page). We are just before readiness and should at least test them out.
Yep. absolutely.
> I'd comment out the rules for staging as in the diff below, if we
> need to drop also the config files on the proxies, I attach a diff
> also for playbooks/groups/proxies.yml.
Yeah, we will need to.
+1 here in any case. Should be fine.
kevin
--
Yeah, sorry, I attached a file. Here are the pre_tasks:
diff --git a/playbooks/groups/proxies.yml b/playbooks/groups/proxies.yml
index 90d5001..1b46198 100644
--- a/playbooks/groups/proxies.yml
+++ b/playbooks/groups/proxies.yml
@@ -74,17 +74,33 @@
# When we have a prerelease we also need to drop the
# config files.
- - name: Remove prerelease-to-final-spins
- file: path=/etc/httpd/conf.d/spins.fedoraproject.org/prerelease-to-final-spins.conf state=absent
+ - name: Remove prerelease-to-final-spins-1
+ file: path=/etc/httpd/conf.d/spins.fedoraproject.org/prerelease-to-final-spins-1.conf state=absent
+ when: env == 'staging'
- - name: Remove prerelease-to-final-labs
- file: path=/etc/httpd/conf.d/labs.fedoraproject.org/prerelease-to-final-labs.conf state=absent
+ - name: Remove prerelease-to-final-spins-2
+ file: path=/etc/httpd/conf.d/spins.fedoraproject.org/prerelease-to-final-spins-2.conf state=absent
+ when: env == 'staging'
+
+ - name: Remove prerelease-to-final-labs-1
+ file: path=/etc/httpd/conf.d/labs.fedoraproject.org/prerelease-to-final-labs-1.conf state=absent
+ when: env == 'staging'
+
+ - name: Remove prerelease-to-final-labs-2
+ file: path=/etc/httpd/conf.d/labs.fedoraproject.org/prerelease-to-final-labs-2.conf state=absent
+ when: env == 'staging'
- name: Remove prerelease-to-final-gfo
file: path=/etc/httpd/conf.d/getfedora.org/prerelease-to-final-gfo.conf state=absent
+ when: env == 'staging'
+
+ - name: Remove prerelease-to-final-arm-1
+ file: path=/etc/httpd/conf.d/arm.fedoraproject.org/prerelease-to-final-arm-1.conf state=absent
+ when: env == 'staging'
- - name: Remove prerelease-to-final-arm
- file: path=/etc/httpd/conf.d/arm.fedoraproject.org/prerelease-to-final-gfo.conf state=absent
+ - name: Remove prerelease-to-final-arm-2
+ file: path=/etc/httpd/conf.d/arm.fedoraproject.org/prerelease-to-final-arm-2.conf state=absent
+ when: env == 'staging'
_______________________________________________ infrastructure mailing list infrastructure@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
