Re: [PATCH] Add eu-central-1 to the fedimg wonderland.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 15, 2015 at 02:31:48PM -0500, Dennis Gilmore wrote:
> On Thursday, October 15, 2015 03:07:50 PM Ralph Bean wrote:
> > ---
> >  roles/fedimg/templates/fedimg.cfg | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/roles/fedimg/templates/fedimg.cfg
> > b/roles/fedimg/templates/fedimg.cfg index bafe26e..e372e53 100644
> > --- a/roles/fedimg/templates/fedimg.cfg
> > +++ b/roles/fedimg/templates/fedimg.cfg
> > @@ -36,6 +36,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
> > ap-northeast-1|RHEL|6.5|x86_64|ami-e7aee0e6|aki-176bf516
> >         ap-southeast-1|RHEL|6.5|x86_64|ami-c683df94|aki-503e7402
> >         ap-southeast-2|RHEL|6.5|x86_64|ami-41ra8f7b|aki-c362fff9
> > +       eu-central-1|RHEL|6.5|x86_64|ami-76eddb6b|aki-184c7a05
> >         eu-west-1|RHEL|6.5|x86_64|ami-81f23cf6|aki-52a34525
> >         sa-east-1|RHEL|6.5|x86_64|ami-b7ec43aa|aki-5553f448
> >         us-west-1|RHEL|6.5|x86_64|ami-fc393eb9|aki-880531cd
> > @@ -44,6 +45,7 @@ amis = us-east-1|RHEL|6.5|x86_64|ami-be6a98d6|aki-919dcaf8
> > ap-northeast-1|RHEL|6.5|i386|ami-c7bff1c6|aki-136bf512
> >         ap-southeast-1|RHEL|6.5|i386|ami-9eb8e4cc|aki-ae3973fc
> >         ap-southeast-2|RHEL|6.5|i386|ami-87f194bd|aki-cd62fff7
> > +       eu-central-1|RHEL|6.5|i386|ami-76eddb6b|aki-184c7a05
> >         eu-west-1|RHEL|6.5|i386|ami-7101cf06|aki-68a3451f
> >         sa-east-1|RHEL|6.5|i386|ami-e9e847f4|aki-5b53f446
> >         us-west-1|RHEL|6.5|i386|ami-eacfc8af|aki-8e0531cb
> ack +1
> 

So, this failed.

- fedimg had a hardcoded list of regions.  eu-central-1 was missing.
- I tried adding the eu-central-1 region, but libcloud didn't have a
  definition for it.
- I tried monkey patching libcloud from fedimg to support
  eu-central-1, and it worked!  https://github.com/fedora-infra/fedimg/pull/39
- I then discovered an older entry from the libcloud changelog that
  showed that the way that fedimg is accessessing the ec2 drivers is
  deprecated.  That's why there's no eu-central-1 definition there,
  because they're trying to phase it out.
- I've got a new patch now that uses this new method.  It works as
  best as I can tell.
  https://github.com/fedora-infra/fedimg/pull/40

With that reviewed, released, and deployed, we should be good to go.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
infrastructure mailing list
infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/infrastructure@xxxxxxxxxxxxxxxxxxxxxxx

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux