On Thu, 2015-06-04 at 09:38 -0600, Kevin Fenzi wrote: > On Thu, 04 Jun 2015 14:35:42 +0200 > Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> wrote: > > > On Fri, 2015-05-29 at 11:56 -0700, Toshio Kuratomi wrote: > > > On Fri, May 29, 2015 at 12:43:32PM +0200, Mathieu Bridon wrote: > > > > If everybody agrees this is the desired behaviour, can we > > > > deploy it in production? > > > > This had been deployed in production, which took me a bit by > > surprise as this discussion didn't seem to have been finished. > > Sorry, this was likely caused by my running the master playbook over > all hosts after our reboots. > > However, the expectation should be that when you commit something to > ansible git you expect it to be pushed out and live. If you don't > want something live, do not yet push it into git, or make sure if you > want only staging to add a 'when' for that. Understood. In the case of files like this script, what is the best way to handle them? Maybe a new dist-git-upload-staging.cgi, and in the playbook conditionalize which file to use with a "when"? > > It caused a bit of a stir due to SELinux (it was disabled in > > staging > > when I tested those changes), but we fixed it with Pierre-Yves: > > > > https://fedorahosted.org/rel-eng/ticket/6191 > > Thanks for the quick work on that. Appreciated. ;) I broke it, I get it to fix it. :) -- Mathieu _______________________________________________ infrastructure mailing list infrastructure@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/infrastructure
