Re: [PATCH] Send SIGHUP to libvirt in notify on all hosts, not just buildhw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 28, 2015, at 01:18 PM, Kevin Fenzi wrote:

> ok, but it's not complete. When you change an handler name, it needs to
> be changed where it's called too.

Ah right, thanks for catching that.

> So, I commited the following, can you see if it meets your needs and if
> not we can adjust it further?

I had to look up `ansible_virtualization_role`, after that it makes sense
to me.

I'm a little grumpy that the long and (IMO) useful and informative commit
message was entirely tossed for a one liner with little historical context.  
I'd have expected at least a link to the mailing list archives in the
commit message.

Regardless thanks for reviewing and fixing!
_______________________________________________
infrastructure mailing list
infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/infrastructure





[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux