On Tue, Feb 24, 2015 at 02:30:04PM -0700, Stephen John Smoogen wrote: > That code made my eyes bleed... so I am not sure I know enough to +1. What > I could tell through the haze looked reasonable. > On 24 February 2015 at 14:06, Pierre-Yves Chibon <pingou@xxxxxxxxxxxx> > wrote: > > Hi all, > > I love when I'm the first one to request a freeze break, so here it is > :) > > Early today we found out that the mechanism restricting access to some > packages > (3) to all but the official maintainers (ie: blocks access to > provenpackagers) > in pkgdb2 is currently broken. > > I've fixed this and Ralph has been kind enough to bare with the code to > review > it: > https://github.com/fedora-infra/pkgdb2/pull/164 > > I would like to backport this patch into a new bug-fix release of pkgdb2 > that I > would deploy tomorrow if I have enough '+1'. > note #1: Bug-fix release as in I'll add the patch to the RPM and build > the RPM > with it, there won't be a new tag in pkgdb or a new release per say. > note #2: this will not go through staging since stg is running the > pre-release of 1.24 that is way ahead of what we have in prod currently. > > On the other side, this has been broken for a little time with > apparently no > side-effect so we could just wait, but since we know it... :) > > Thoughts? +1? -1? This is now running in prod as part of pkgdb2-1.23-6: https://admin.fedoraproject.org/pkgdb/api/vcs (ctrl+f firefox) @stephen, there is a ticket to make this part of the code be a little more readable by using proper variable names ;-) Pierre _______________________________________________ infrastructure mailing list infrastructure@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/infrastructure
