[freeze break request] Make resolv.conf get installed before packages are installed in base.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In ansible's base role, we install packages before setting resolv.conf.
But if resolv.conf isn't set, DNS queries don't necessarily work (e.g.
when setting up a new virthost for the first time).

This patch moves the resolv.conf task up to the top of the base role to
ensure it's in place before we do anything requiring DNS lookups.

+1's?

-Ricky

diff --git a/roles/base/tasks/main.yml b/roles/base/tasks/main.yml
index 3b71e9c..7af5095 100644
--- a/roles/base/tasks/main.yml
+++ b/roles/base/tasks/main.yml
@@ -4,6 +4,21 @@
 # This is the base role for all machines.
 # Things in here are things we want to do to every machine no matter what.
 #
+
+# XXX fixme # a datacenter 'fact' from setup
+- name: /etc/resolv.conf
+  copy: src={{ item }} dest=/etc/resolv.conf
+  with_first_found:
+  - "{{ resolvconf }}"
+  - resolv.conf/{{ ansible_fqdn }}
+  - resolv.conf/{{ host_group }}
+  - resolv.conf/{{ datacenter }}
+  - resolv.conf/resolv.conf
+  tags:
+  - config
+  - resolvconf
+  - base
+
 - name: global default packages to install
   yum: state=installed name={{ item }}
   with_items:
@@ -111,20 +126,6 @@
   - config
   - base

-# XXX fixme # a datacenter 'fact' from setup
-- name: /etc/resolv.conf
-  copy: src={{ item }} dest=/etc/resolv.conf
-  with_first_found:
-  - "{{ resolvconf }}"
-  - resolv.conf/{{ ansible_fqdn }}
-  - resolv.conf/{{ host_group }}
-  - resolv.conf/{{ datacenter }}
-  - resolv.conf/resolv.conf
-  tags:
-  - config
-  - resolvconf
-  - base
-
 - name: rsyslog.conf
   copy: src={{ item }} dest=/etc/rsyslog.conf mode=644
   with_first_found:

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
infrastructure mailing list
infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/infrastructure

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux