On Fri, 14 Jun 2013 12:25:03 +0200 Pierre-Yves Chibon <pingou@xxxxxxxxxxxx> wrote: > On Fri, 2013-06-14 at 10:15 +0000, Pierre-Yves Chibon wrote: > > Couple of questions regarding my changes: > > > .../nodes/datagrepper01.phx2.fedoraproject.org.pp | 2 + > > I put the cron on datagrepper01, is it fine or can we think of a > better place? Probibly ok for now, we have talked about a 'oddjobs' box to run scripts that don't need any special access, but haven't gotten to it yet. > > modules/owner_changes/files/fedora-owner-change.py | 232 > > ++++++++++++++++++++ > > modules/owner_changes/manifests/init.pp | 23 ++ > > I directly put it on modules, rather than modules-stg as it sends an > email. > Maybe we could adjust the cron job to send an email to this list as a > test and just change to send to devel after this? Sure. Sounds like a good test. I'm not sure this needs to be it's own module. Could we just add it to scripts module? > The cron is configured as: > > + minute => 0, > > + hour => 12, > > + weekday => 1, > ie: Every Monday at 12:00 > > and the python script as: > > +DELTA = 7 * 24 * 60 * 60 # 7 day > (I just adjusted it, apparently I was missing it) You also seem to have: + cron { "gather-easyfix": That should be changed? ;) > Finally, related the first question, will: > > +SMTP_SERVER = 'localhost' > work on datagrepper01? It should I think. kevin
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ infrastructure mailing list infrastructure@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/infrastructure