Change Request - email alias handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Right now FAS constructs email aliases only for accounts that are active. This is causing us two problems.

1) We have recently implemented a "bot" status for accounts that makes it so the account can't be logged into and don't go inactive. This status needs to be allowed to get email as well.

2) inactive accounts are bouncing mail, not just from the pkgdb which I've been handling and have a mid-term and long-term plan for fixing but also for the wiki watch-page function which we currently don't have a good mid-term plan for. Restoring aliases for inactive accounts seems like the best short-term solution for this.

Fixing these requires updating the fas server code. Attaching a patch to hotfix our servers with to do this. The patch has been tested on fas1.stg successfully.

-Toshio
diff --git a/fas/user.py b/fas/user.py
index 236187b..627cb8e 100644
--- a/fas/user.py
+++ b/fas/user.py
@@ -534,7 +534,7 @@ https://admin.fedoraproject.org/accounts/user/edit/%(username)s
             search = unicode(search, 'utf-8', 'replace')
 
         re_search = search.translate({ord(u'*'): ur'%'}).lower()
-        people = People.query.filter(and_(People.username.like(re_search), People.status == 'active')).order_by('username')
+        people = People.query.filter(and_(People.username.like(re_search), People.status.in_('active', 'bot', 'inactive'))).order_by('username')
         emails = {}
         # Run filter_private via side effect
         for person, discard in ((p, p.filter_private()) for p in people):
_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux