On Sat, Nov 22, 2008 at 06:41:34PM -0500, Luke Macken wrote: > As some of you may have noticed, the last batch of updates contained 209 > updates with the ID of 'FEDORA-2008-10000'. This is is due to a flaw in the > way bodhi's PackageUpdate.assign_id() method finds the current update with the > highest id. Presently, it does a PackageUpdate.select(..., > orderBy=PackageUpdate.q.updateid). Since PackageUpdate.updateid is a unicode > column, and due to the fact that u'FEDORA-2008-10000' < u'FEDORA-2008-9999', > this started to fail miserably. > > Attached is a patch that has the assign_id method order the query by the > date_pushed DateTimeCol in order to find the highest updateid. However, it > seems that SQLObject completely ignore milliseconds: > > if datetime: > def DateTimeConverter(value, db): > return "'%04d-%02d-%02d %02d:%02d:%02d'" % ( > value.year, value.month, value.day, > value.hour, value.minute, > value.second) > > The problem with this is that we must now take into account multiple updates > that were pushed at the same second. > > The "proper" way to fix this is at the model level, and probably to use an > integer for the updateid column. I'm in the process of finishing up the > SQLAlchemy port, which will properly solve this problem. In the mean time, > this hack will not require any database changes. > > This patch also includes a test case for this 10k bug. > > [lmacken@x300 bodhi]$ nosetests > bodhi/tests/test_model.py:TestPackageUpdate.test_id > . > ---------------------------------------------------------------------- > Ran 1 test in 0.084s > > OK > > Once approved and applied, I will push out a fixed package (to releng2 only), > fix the existing updates from the last push, and send out an errata containing > the new update IDs. Earlier today I pushed out a fixed bodhi-server to releng2, reassigned 209 update ids, and remashed the f10 updates repositories. I also sent an errata to the fedora-package-announce list, but it has yet to be moderated, so it is attached as well. Cheers, luke
>From lmacken@xxxxxxxxxx Mon Nov 24 15:51:42 2008 Date: Mon, 24 Nov 2008 15:51:42 -0500 From: Luke Macken <lmacken@xxxxxxxxxx> To: fedora-package-announce@xxxxxxxxxx Subject: ERRATA: Incorrect update IDs Message-ID: <20081124205142.GA17090@xxxxxxxxxxxxxxxxxxx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Status: RO Content-Length: 10363 Lines: 242 --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Due to a bug in bodhi[0], the most recent push of updates contained many with the ID of FEDORA-2008-10000. This bug has since been fixed, and new IDs have been reassigned to those updates, which are listed below. Sorry for the inconvenience, luke [0]: https://www.redhat.com/archives/fedora-infrastructure-list/2008-November/msg00150.html ================================================================================ FEDORA-2008-10000 rpcbind-0.1.7-1.fc9 FEDORA-2008-10001 perl-IO-Socket-SSL-1.18-1.fc10 FEDORA-2008-10002 unikurd-web-font-20020502-1.fc10 FEDORA-2008-10003 gyachi-1.1.56-5.fc10 FEDORA-2008-10004 ifstat-1.1-8.fc10 FEDORA-2008-10005 libetpan-0.57-1.fc10 FEDORA-2008-10006 perl-Data-Visitor-0.21-1.fc10 FEDORA-2008-10007 postgresql-8.3.5-1.fc10 FEDORA-2008-10008 scim-chewing-0.3.2-1.fc10 FEDORA-2008-10009 gnome-gmail-notifier-0.9.4-3.fc10 FEDORA-2008-10010 geda-gnetlist-20080929-2.fc10 FEDORA-2008-10011 libpng-1.2.33-1.fc10 FEDORA-2008-10012 codeblocks-8.02-4.fc10 FEDORA-2008-10013 xdvik-22.84.14-4.fc10 FEDORA-2008-10014 darcs-2.1.0-1.fc10 FEDORA-2008-10015 rcssmonitor-13.0.0-2.fc10 FEDORA-2008-10016 bacula-2.4.3-3.fc10 FEDORA-2008-10017 basket-1.0.3.1-2.fc10 FEDORA-2008-10018 libnfnetlink-0.0.39-3.fc10 FEDORA-2008-10019 clipper-2.0-20.fc10 FEDORA-2008-10020 linux-libertine-fonts-4.1.8-1.fc10 FEDORA-2008-10021 pngnq-0.5-5.fc10 FEDORA-2008-10022 rpcbind-0.1.7-1.fc10 FEDORA-2008-10023 VLGothic-fonts-20081029-1.fc10 FEDORA-2008-10024 dvipng-1.11-1.fc10 FEDORA-2008-10025 gyachi-1.1.56-5.fc8 FEDORA-2008-10026 ochusha-0.5.99.67.1-0.4.cvs20081114T2135.fc10 FEDORA-2008-10027 file-browser-applet-0.6.0-1.fc10 FEDORA-2008-10028 em8300-0.17.2-1.fc10 FEDORA-2008-10029 grip-3.2.0-25.fc10 FEDORA-2008-10030 gnome-power-manager-2.24.2-2.fc10 FEDORA-2008-10031 ruby-libvirt-0.1.0-2.fc10 FEDORA-2008-10032 plt-scheme-4.1.2-1.fc10 FEDORA-2008-10033 perl-Crypt-DSA-0.14-7.fc10,perl-Crypt-DH-0.06-9.fc10 FEDORA-2008-10034 system-config-services-0.99.28-1.fc10 FEDORA-2008-10035 bind-9.5.1-0.9.b3.fc10 FEDORA-2008-10036 appliance-tools-003.9-1.fc10 FEDORA-2008-10037 eclipse-cdt-5.0.0-12.fc10 FEDORA-2008-10038 libxml2-2.7.2-2.fc10 FEDORA-2008-10039 perl-MooseX-Types-Path-Class-0.05-3.fc10 FEDORA-2008-10040 olpc-netutils-0.7-2.fc10 FEDORA-2008-10041 global-5.7.3-1.fc9 FEDORA-2008-10042 srecord-1.45-1.fc10 FEDORA-2008-10043 varnish-2.0.2-1.fc10 FEDORA-2008-10044 perl-Net-SSH-Perl-1.33-2.fc10 FEDORA-2008-10045 spu-binutils-2.18.50.0.9-9.fc10 FEDORA-2008-10046 wxsvg-1.0-2.fc10 FEDORA-2008-10047 linuxwacom-0.8.0.3-6.fc10 FEDORA-2008-10048 otl-4.0.176-5.fc10 FEDORA-2008-10049 zabbix-1.6.1-1.fc10 FEDORA-2008-10050 ikiwiki-2.70-1.fc10 FEDORA-2008-10051 evolution-exchange-2.24.1.1-1.fc10 FEDORA-2008-10052 rcssserver-13.0.1-1.fc10 FEDORA-2008-10053 python-twitter-0.5-1.fc10 FEDORA-2008-10054 mfiler3-2.1.3-1.fc10 FEDORA-2008-10055 ufiformat-0.9.4-3.fc10 FEDORA-2008-10056 eric-4.2.3-1.fc10 FEDORA-2008-10057 tzdata-2008i-1.fc10 FEDORA-2008-10058 perl-Mail-Box-2.084-1.fc10 FEDORA-2008-10059 libetpan-0.57-1.fc9 FEDORA-2008-10060 nebula-0.2.2-5.fc10 FEDORA-2008-10061 tog-pegasus-2.7.1-3.fc10 FEDORA-2008-10062 xorg-x11-xdm-1.1.6-6.fc10 FEDORA-2008-10063 cluster-2.99.12-2.fc10 FEDORA-2008-10064 purple-microblog-0.2.0-1.fc10 FEDORA-2008-10065 unbound-1.0.2-5.fc10 FEDORA-2008-10066 vdr-remote-0.4.0-5.fc10 FEDORA-2008-10067 gnomesword-2.4.1-1.fc8 FEDORA-2008-10068 yumex-2.0.5-3.fc10 FEDORA-2008-10069 cobbler-1.2.9-1.fc10 FEDORA-2008-10070 darkice-0.19-3.fc10 FEDORA-2008-10071 augeas-0.3.4-1.fc10 FEDORA-2008-10072 gyachi-1.1.55-5.fc10 FEDORA-2008-10073 libwfut-0.2.1-2.fc10 FEDORA-2008-10074 python-lxml-2.1.3-1.fc10 FEDORA-2008-10075 audit-1.7.9-1.fc10 FEDORA-2008-10076 bro-1.4-0.3.20080804svn.fc10 FEDORA-2008-10077 decibel-audio-player-0.11-1.fc10 FEDORA-2008-10078 homestead-0.94-1.fc10 FEDORA-2008-10079 artwiz-aleczapka-fonts-1.3-6.fc10 FEDORA-2008-10080 rtorrent-0.8.3-1.fc10 FEDORA-2008-10081 warzone2100-2.1.0-0.7.beta5.fc10 FEDORA-2008-10082 dopewars-1.5.12-4.fc10 FEDORA-2008-10083 kvm-74-6.fc10 FEDORA-2008-10084 lout-3.38-1.fc10 FEDORA-2008-10085 xorg-x11-drv-radeonhd-1.2.3-1.5.20081112git.fc10 FEDORA-2008-10086 sympy-0.6.2-2.fc10 FEDORA-2008-10087 ucblogo-6.0-2.fc10 FEDORA-2008-10088 libprojectM-1.2.0-5.fc10 FEDORA-2008-10089 bam-0.0.0.4.3-1.fc10 FEDORA-2008-10090 libnxml-0.18.3-2.fc9 FEDORA-2008-10091 eclipse-phpeclipse-1.2.1-2.fc10 FEDORA-2008-10092 tkimg-1.4-0.1.20081115svn.fc10 FEDORA-2008-10093 ruby-RMagick-2.7.2-1.fc10 FEDORA-2008-10094 ttf2pt1-3.4.4-7.fc10 FEDORA-2008-10095 rmanage-0.1.5-2.fc10 FEDORA-2008-10096 ucblogo-6.0-1.fc9 FEDORA-2008-10097 mmdb-1.19-2.fc10 FEDORA-2008-10098 pngcrush-1.6.10-3.fc10 FEDORA-2008-10099 sugar-base-0.82.2-4.fc10 FEDORA-2008-10100 joda-time-1.5.2-10.tzdata2008i.fc10 FEDORA-2008-10101 texmaker-1.8-1.fc9 FEDORA-2008-10102 perl-Catalyst-Engine-Apache-1.12-2.fc10 FEDORA-2008-10103 kcirbshooter-0.04-2.fc10 FEDORA-2008-10104 python-zope-interface-3.5.0-1.fc10.1 FEDORA-2008-10105 scala-2.7.2-1.fc10 FEDORA-2008-10106 sdcc-2.8.0-3.fc10 FEDORA-2008-10107 daa2iso-0.1.7a-1.fc10 FEDORA-2008-10108 perl-URI-FromHash-0.03-3.fc10 FEDORA-2008-10109 php-ZendFramework-1.7.0-2.fc10 FEDORA-2008-10110 sfxr-1.1-1.fc10 FEDORA-2008-10111 gpsbabel-1.3.6-1.fc10 FEDORA-2008-10112 ksplice-0.9.3-2.fc10 FEDORA-2008-10113 obexd-0.8-1.fc10 FEDORA-2008-10114 pympdtouchgui-0.302-5.fc10 FEDORA-2008-10115 nabi-0.99.2-1.fc10 FEDORA-2008-10116 scrub-2.1-1.fc10 FEDORA-2008-10117 rubygem-rspec-1.1.11-1.fc10 FEDORA-2008-10118 gnome-applet-sensors-2.2.1-1.fc10 FEDORA-2008-10119 gwibber-0.7.1-1.134bzr.fc10 FEDORA-2008-10120 perl-Catalyst-Plugin-Session-Store-FastMmap-0.05-2.fc10 FEDORA-2008-10121 lynis-1.2.1-3.fc10 FEDORA-2008-10122 pyke-0.5-1.fc10 FEDORA-2008-10123 olpc-utils-0.89-6.fc10 FEDORA-2008-10124 biniax-1.2-4.fc10 FEDORA-2008-10125 ql23xx-firmware-3.03.27-1.fc10 FEDORA-2008-10126 grip-3.2.0-24.fc10 FEDORA-2008-10127 drupal-date-6.x.2.0-2.rc4.fc10 FEDORA-2008-10128 python-fedora-0.3.8-1.fc9 FEDORA-2008-10129 java-1.6.0-openjdk-1.6.0.0-4.b12.fc10 FEDORA-2008-10130 piklab-0.15.3-2.fc10,toped-0.9.2-2.fc10,libgeda-20080929-1.fc10 FEDORA-2008-10131 memtest86+-2.10-1.fc10 FEDORA-2008-10132 wxMaxima-0.7.6-1.fc10 FEDORA-2008-10133 m17n-contrib-1.1.8-2.fc10 FEDORA-2008-10134 referencer-1.1.5-2.fc10 FEDORA-2008-10135 sugar-turtleart-16-1.fc10 FEDORA-2008-10136 libsqlite3x-20071018-4.fc10 FEDORA-2008-10137 gtkhtml3-3.24.1.1-1.fc10 FEDORA-2008-10138 homestead-0.93-1.fc10 FEDORA-2008-10139 perl-XML-LibXSLT-1.66-2.fc10 FEDORA-2008-10140 gnomesword-2.4.1-1.fc10 FEDORA-2008-10141 setroubleshoot-2.0.12-3.fc10 FEDORA-2008-10142 ssm-0.1-9.fc10 FEDORA-2008-10143 drupal-cck-6.x.2.0-3.fc10 FEDORA-2008-10144 pstreams-devel-0.6.0-6.fc10 FEDORA-2008-10145 deluge-1.0.5-1.fc10 FEDORA-2008-10146 paps-0.6.8-8.fc10 FEDORA-2008-10147 ski-1.3.2-6.fc10 FEDORA-2008-10148 libtirpc-0.1.10-1.fc9 FEDORA-2008-10149 kazehakase-0.5.6-1.fc10 FEDORA-2008-10150 perl-Catalyst-Manual-5.7014-1.fc10 FEDORA-2008-10151 eclipse-gef-3.4.1-1.fc10 FEDORA-2008-10152 xlcrack-1.2-2.fc10 FEDORA-2008-10153 gnumeric-1.8.2-4.fc10 FEDORA-2008-10154 rubygem-fastthread-1.0.1-1.fc10 FEDORA-2008-10155 freetalk-3.2-1.fc9 FEDORA-2008-10156 rxtx-2.1-0.2.7r2.fc10 FEDORA-2008-10157 libX11-1.1.4-6.fc10 FEDORA-2008-10158 setup-2.7.4-2.fc10 FEDORA-2008-10159 nspluginwrapper-1.1.4-1.fc10 FEDORA-2008-10160 olpcsound-5.08.92-12.fc10 FEDORA-2008-10161 util-linux-ng-2.14.1-3.1.fc10 FEDORA-2008-10162 gnutls-2.4.2-3.fc10 FEDORA-2008-10163 gnash-0.8.4-5.fc10 FEDORA-2008-10164 subcommander-1.9.94-3.fc10 FEDORA-2008-10165 translate-toolkit-1.2.0-3.fc10 FEDORA-2008-10166 libev-3.48-1.fc10 FEDORA-2008-10167 barry-0.14-4.fc10 FEDORA-2008-10168 evolution-sharp-0.18.1-1.fc10 FEDORA-2008-10169 zfs-fuse-0.5.0-3.20081009.fc10 FEDORA-2008-10170 gpp4-1.0.4-11.fc10 FEDORA-2008-10171 emacs-vm-8.0.12-2.fc10 FEDORA-2008-10172 florence-0.3.0-2.fc10 FEDORA-2008-10173 referencer-1.1.5-2.fc8 FEDORA-2008-10174 collectl-3.1.1-1.fc10 FEDORA-2008-10175 PackageKit-0.3.10-1.fc10,gnome-packagekit-0.3.10-1.fc10 FEDORA-2008-10176 rpmlint-0.85-2.fc10 FEDORA-2008-10177 nettee-0.1.9-3.fc10 FEDORA-2008-10178 filezilla-3.1.5.1-1.fc10 FEDORA-2008-10179 arp-scan-1.7-2.fc10 FEDORA-2008-10180 ldns-1.4.0-1.fc10 FEDORA-2008-10181 diveintopython-5.4-14.fc10 FEDORA-2008-10182 xorg-x11-proto-devel-7.4-5.fc10 FEDORA-2008-10183 eclipse-gef-3.3.2-1.fc9 FEDORA-2008-10184 cairo-dock-1.6.3.1-1.fc10 FEDORA-2008-10185 winpdb-1.4.2-1.fc10 FEDORA-2008-10186 gyachi-1.1.57-5.fc8 FEDORA-2008-10187 taginfo-1.2-1.fc10 FEDORA-2008-10188 sed-4.1.5-11.fc10 FEDORA-2008-10189 cpuspeed-1.5-2.fc10 FEDORA-2008-10190 php-pecl-ssh2-0.10-2.fc10 FEDORA-2008-10191 eterm-0.9.5-2.fc10 FEDORA-2008-10192 expendable-0.0.7-1.fc10 FEDORA-2008-10193 libgtop2-2.24.0-2.fc10 FEDORA-2008-10194 gyachi-1.1.57-5.fc10 FEDORA-2008-10195 selinux-policy-3.5.13-20.fc10 FEDORA-2008-10196 git-1.6.0.4-1.fc10 FEDORA-2008-10197 quota-3.16-6.fc10 FEDORA-2008-10198 xwota-0.4-5.fc10 FEDORA-2008-10199 nspr-4.7.3-1.fc10 FEDORA-2008-10200 ruby-gnome2-0.18.1-1.fc10 FEDORA-2008-10201 rcssserver-13.0.0-1.fc10 FEDORA-2008-10202 gyachi-1.1.56-5.fc9 FEDORA-2008-10203 smolt-1.1.1.1-8.fc10 FEDORA-2008-10204 maxima-5.16.3-4.fc10,sbcl-1.0.22-1.fc10 FEDORA-2008-10205 perl-File-Comments-0.07-1.fc10 FEDORA-2008-10206 konq-plugins-4.1.3-2.fc10,kiconedit-4.1.3-2.fc10,kcoloredit-4.1.3-1.fc10,guidance-power-manager-4.1.3-1.fc10,kdeaccessibility-4.1.3-1.fc10,kdeadmin-4.1.3-1.fc10,kdeartwork-4.1.3-2.fc10,kdebase-4.1.3-2.fc10,kdebase-runtime-4.1.3-1.fc10,kdebase-workspace-4.1.3-6.fc10,kdebindings-4.1.3-1.fc10,kdeedu-4.1.3-1.fc10,kdegames-4.1.3-1.fc10,kdegraphics-4.1.3-1.fc10,kdelibs-4.1.3-3.fc10,kdemultimedia-4.1.3-1.fc10,kdenetwork-4.1.3-1.fc10,kdepim-4.1.3-1.fc10,kdepimlibs-4.1.3-1.fc10,kdeplasma-addons-4.1.3-1.fc10,kdesdk-4.1.3-1.fc10,kdetoys-4.1.3-1.fc10,kdeutils-4.1.3-1.fc10,kde-l10n-4.1.3-1.fc10 FEDORA-2008-10207 pyroom-0.3.1.1-4.fc10 FEDORA-2008-10208 evolution-data-server-2.24.1.1-1.fc10 --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkkrE94ACgkQRsm3eDkOu7mqqACdGvYXKSQANaoNYPXfrljagu5r UI8An0oKE/wLX0JESvK+Zw/7oqneJD5k =HC5r -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6--
_______________________________________________ Fedora-infrastructure-list mailing list Fedora-infrastructure-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list