Re: tests take minutes to start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 13, 2020 at 12:05 PM William Brown <wbrown@xxxxxxx> wrote:
>
> It's due to the way that docker for mac works, the IO pipe to the container is via the CPU path, so anything that needs a grep like this will take a long time.
OK, that's why I asked about 'other OS' :)
Have you tried mounting volumes via nfsmount [1]?
In the meantime, I'm working on integrating pre-commit [2] and various
linters/checkers for lib389. I think we can add another hook that will
generate markers for pytest.ini.

[1] https://www.jeffgeerling.com/blog/2020/revisiting-docker-macs-performance-nfs-volumes
[2] https://pre-commit.com/
>
> > On 13 May 2020, at 17:15, Viktor Ashirov <vashirov@xxxxxxxxxx> wrote:
> >
> > On Wed, May 13, 2020 at 9:13 AM William Brown <wbrown@xxxxxxx> wrote:
> >>
> >>
> >>
> >>> On 13 May 2020, at 17:01, Viktor Ashirov <vashirov@xxxxxxxxxx> wrote:
> >>>
> >>> Hi,
> >>>
> >>> On Wed, May 13, 2020 at 8:31 AM William Brown <wbrown@xxxxxxx> wrote:
> >>>>
> >>>> Hi all,
> >>>>
> >>>> I noticed today that my tests now take minutes to start executing. It looks like it's spinning on:
> >>>>
> >>>> dirsrv   84605 12.8  0.1  16672  7704 pts/0    S+   16:25   0:08 grep -rh ^@pytest.mark.\(ds\|bz\)[0-9]\+
> >>>>
> >>>> Do we know anything about this? Did we add something in a fixture or something to grep for tests? That kind of pattern does look like our bz/ds here, so I suspect it comes from us.
> >>> It is this change:
> >>> https://pagure.io/389-ds-base/c/6a7a154159583c09fcbba0578eaf576d577ccb11?branch=master
> >>> But for me on Fedora it doesn't take minutes:
> >>> $ time grep -rh ^@pytest.mark.\(ds\|bz\)[0-9]\+
> >>>
> >>> real 0m0.144s
> >>> user 0m0.093s
> >>> sys 0m0.050s
> >>>
> >>> How are you running your tests? Is it on OpenSUSE or some other OS?
> >>
> >> It's a known IO performance issue inside of docker.
> > Do you mount a volume with git/tests inside of the container or it's
> > in the container FS itself?
> >>
> >>> Thanks.
> >>>>
> >>>>
> >>>>
> >>>> —
> >>>> Sincerely,
> >>>>
> >>>> William Brown
> >>>>
> >>>> Senior Software Engineer, 389 Directory Server
> >>>> SUSE Labs
> >>>> _______________________________________________
> >>>> 389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> >>>> To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> >>>> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >>>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >>>> List Archives: https://lists.fedoraproject.org/archives/list/389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> >>>
> >>>
> >>>
> >>> --
> >>> Viktor
> >>> _______________________________________________
> >>> 389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> >>> To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> >>> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >>> List Archives: https://lists.fedoraproject.org/archives/list/389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> >>
> >> —
> >> Sincerely,
> >>
> >> William Brown
> >>
> >> Senior Software Engineer, 389 Directory Server
> >> SUSE Labs
> >> _______________________________________________
> >> 389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> >> To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> >> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >> List Archives: https://lists.fedoraproject.org/archives/list/389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> >
> >
> >
> > --
> > Viktor
> > _______________________________________________
> > 389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> > To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: https://lists.fedoraproject.org/archives/list/389-devel@xxxxxxxxxxxxxxxxxxxxxxx
>
> —
> Sincerely,
>
> William Brown
>
> Senior Software Engineer, 389 Directory Server
> SUSE Labs
> _______________________________________________
> 389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/389-devel@xxxxxxxxxxxxxxxxxxxxxxx



-- 
Viktor
_______________________________________________
389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-devel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux