|
On 03/20/2017 02:47 AM, William Brown
wrote:
+1 (or it may be +0.5 value now, though... ;)Hi all, I've noticed that sometimes during the review process that the following happens: Europe Afternoon: code is posted to review. America Morning: code is acked Europe Afternoon: code is merged <Hours pass> Australian Morning: "I have this comment, but the code is already merged ...." Then we need to make extra "fixup patches" instead. I wonder if we could suggest that there is a mandatory 24 hour review window. Code once posted for review and prior to merge must be: * ack's from all reviewers * online for 24 hours since submission before merge We have a global team, and sometimes it's easy for us to forget this and not let everyone have the chance to have their say. This review process is really valuable to us all, so it's best if we can all input to this as it raises the standard of our project. I think the exception would be some kind of pressure (critical issues, blocker, build chain break, broken nightly tests) where we would waive the 24 hour review period. Does this seem like a reasonable change we could make as a team to give all of us the chance to review. --noriko
|
_______________________________________________ 389-devel mailing list -- 389-devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to 389-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
