On 09/04/2016 07:12 PM, William Brown wrote:
On Sat, 2016-09-03 at 18:07 +0200, Lukas Slebodnik wrote:
ehlo,
https://fedorahosted.org/389/ticket/48979
The 1st 16 patches are preparation for a last huge patch
which uses "(void)" for functions which does not expect
any arguments.
I have tested and acked this patch series already.
This is an extra patch to fix a few missed functions:
https://fedorahosted.org/389/attachment/ticket/48979/0002-Ticket-48979-Strict-Prototypes.patch
Hi Lukas, Hi William,
Thank you for the great effort for cleaning up the code. I also
reviewed the code and they look good.
Maybe, we should adjust all of them in one patch after the push, but if
we could avoid adding mismatched indentation, that'd be nice... We
already have quite a lot of places which look ugly... It sometimes make
the reviewer confused.
Thanks,
--noriko
--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/389-devel@xxxxxxxxxxxxxxxxxxxxxxx
