|
On 10.06.2016 07:21, William Brown
wrote:
https://fedorahosted.org/389/ticket/48878 https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pep8-fixes-and-fix-rpm-to-build.patch https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pep8-fixes-part-2.patch Hello, some notes if I can :) 1) This change is harder to read with PEP8 - topology.standalone.backends.create(None, - properties={ - BACKEND_NAME: NEW_BACKEND_1, - 'suffix':NEW_SUFFIX_1, - }) + topology.standalone.backends.create(None, properties={ + BACKEND_NAME: NEW_BACKEND_1, + 'suffix': NEW_SUFFIX_1, + }) ents = topology.standalone.backends.list() for ent in ents: topology.standalone.log.info("List(%d): backend %s" % I suggest to use topology.standalone.backends.create( None, properties={ BACKEND_NAME: NEW_BACKEND_1, 'suffix': NEW_SUFFIX_1, }) Same for NEW_BACKEND_2 2) I'm not sure if change in python-lib389.spec belongs to PEP8 related patch or if it is related to PEP8 Otherwise LGTM for PEP8 fixes :) Martin Basti @ IPA |
-- 389-devel mailing list 389-devel@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/389-devel@xxxxxxxxxxxxxxxxxxxxxxx
