[389-devel] Please review: [nunc-stans] Remove extra curly brace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ehlo,

I'm too lazy to follow all contribution steps for one liner :-)
So simple patch is attached.

LS
>From 30aed3d8879338c8713d845803cd178beab9c57d Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn@xxxxxxxxxx>
Date: Tue, 10 Nov 2015 10:16:46 +0100
Subject: [PATCH] Remove extra curly brace

src/ringbuffer/ringbuffer_get_and_put.c:17:3: warning: control may reach end of non-void function [-Wreturn-type]
  }
  ^
src/ringbuffer/ringbuffer_get_and_put.c:19:18: error: unknown type name 'rs'
  queue_dequeue( rs->qs, (void **) fe );
                 ^
src/ringbuffer/ringbuffer_get_and_put.c:19:20: error: expected ')'
  queue_dequeue( rs->qs, (void **) fe );
                   ^
src/ringbuffer/ringbuffer_get_and_put.c:19:16: note: to match this '('
  queue_dequeue( rs->qs, (void **) fe );
               ^
src/ringbuffer/ringbuffer_get_and_put.c:19:3: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
  queue_dequeue( rs->qs, (void **) fe );
  ^
src/ringbuffer/ringbuffer_get_and_put.c:21:3: error: expected identifier or '('
  return( *fe );
  ^
src/ringbuffer/ringbuffer_get_and_put.c:22:1: error: extraneous closing brace ('}')
}
^
2 warnings and 4 errors generated.
---
 liblfds/src/ringbuffer/ringbuffer_get_and_put.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/liblfds/src/ringbuffer/ringbuffer_get_and_put.c b/liblfds/src/ringbuffer/ringbuffer_get_and_put.c
index 625ed6e23020645b352824b01f0ad9cb74cbc8be..e7bc9ad7aba538cfa8bb9281454e09d4a354a706 100644
--- a/liblfds/src/ringbuffer/ringbuffer_get_and_put.c
+++ b/liblfds/src/ringbuffer/ringbuffer_get_and_put.c
@@ -13,7 +13,6 @@ struct freelist_element *ringbuffer_get_read_element( struct ringbuffer_state *r
     assert( fe != NULL );
 #endif
       return NULL;
-    }
   }
 
   queue_dequeue( rs->qs, (void **) fe );
-- 
2.5.0

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux