Re: [389-devel] Please comment: [389 Project] #48285: The dirsrv user/group should be created in rpm %pre, and ideally with fixed uid/gid

[Rich Megginson <rmeggins@xxxxxxxxxx>]

On 10/21/2015 12:20 PM, Noriko Hosoi wrote:

Thanks to William for his reviewing the patch.  I'm going to push it.  But before doing so, I have a question regarding the autogen files.

The proposed patch requires to rerun autogen.sh and push the generated files to the git.  My current env has automake 1.15 and it generates large diffs as attached to this email.
-# Makefile.in generated by automake 1.13.4 from Makefile.am.
+# Makefile.in generated by automake 1.15 from Makefile.am.

Is it okay to push the attached patch 0002-Ticket-48285-The-dirsrv-user-group-should-be-created.patch to git or do we prefer to keep the diff minimum by runing autogen on the host having the same version of automake (1.13.4)?

Should confirm that the generated configure script runs on el7

Thanks,
--noriko

On 10/20/2015 05:48 PM, Noriko Hosoi wrote:

https://fedorahosted.org/389/ticket/48285

https://fedorahosted.org/389/attachment/ticket/48285/0001-Ticket-48285-The-dirsrv-user-group-should-be-created.patch
git patch file (master) -- revised

If these users and groups exist on the system:

/etc/passwd:xdirsrv:x:389:389:389-ds-base:/usr/share/dirsrv:/sbin/nologin
/etc/passwd:dirsrvy:x:390:390:389-ds-base:/usr/share/dirsrv:/sbin/nologin
/etc/group:xdirsrv:x:389:
/etc/group:dirsrvy:x:390:

This pair is supposed to be generated:

/etc/passwd:dirsrv:x:391:391:389-ds-base:/usr/share/dirsrv:/sbin/nologin
/etc/group:dirsrv:x:391:


-- 
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel