On Thu, 2015-08-06 at 16:13 -0400, Mark Reynolds wrote: > https://fedorahosted.org/389/ticket/47703 > > https://fedorahosted.org/389/attachment/ticket/47703/0001-Ticket-47703-remove- > search-limit-for-aci-group-evalu.patch > -- > 389-devel mailing list > 389-devel@xxxxxxxxxxxxxxxxxxxxxxx > https://admin.fedoraproject.org/mailman/listinfo/389-devel I'm having a read through of this to try and understand more about this, and hopefully to help with your review. Why was the search limit added initially into the aci plugin? By deleting this code, is there some other edge case that it may cause? Would it be possible to make a unit test case for this. If you set the sizelimit in cn=config to be low, say 5, you could easily make a group that has more members, and then evaluate aci behaviour in a unit test? If you are busy perhaps that's something I could knock up and test if you were happy for me to do so. Sincerely, -- William Brown <william@xxxxxxxxxxxxxxxx> -- 389-devel mailing list 389-devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/389-devel
