[389-devel] Please review: [389 Project] #47939: Malformed cookie for LDAP Sync makes DS crash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://fedorahosted.org/389/ticket/47939

https://fedorahosted.org/389/attachment/ticket/47939/0001-Ticket-47939-Malformed-cookie-for-LDAP-Sync-makes-DS.patch

Note: I added additional check for the cookie_change_info value.  If non-digit is given, it is now releasing Sync_Cookie and return NULL.
* Format of cookie: server_signature#client_signature#change_info_number
--- a/ldap/servers/plugins/sync/sync_util.c
+++ b/ldap/servers/plugins/sync/sync_util.c
@@ -574,21 +574,32 @@ sync_cookie_parse (char *cookie)
            *p = '\0';
            sc->cookie_client_signature = slapi_ch_strdup(q);
            sc->cookie_change_info = sync_number2int(p+1);
+           if (sc->cookie_change_info < 0) {
+               goto error_return;
+           }

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux