Re: [389-devel] Please review lib389: start/stop may hand indefinitely

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/05/2014 01:10 PM, thierry bordaz wrote:
Detected with testcase 47838 that defines ciphers not recognized during SSL init. 47838 testcase makes the full test suite to hang.


--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Hello,

Rich pointed me that the indentation was bad in the second part of the fix. I was wrongly playing with tab instead of spaces.
Here is a better fix

thanks
theirry
From fd7011e0d9a081f5702b560136541d73f6dd0dc5 Mon Sep 17 00:00:00 2001
From: "Thierry bordaz (tbordaz)" <tbordaz@xxxxxxxxxx>
Date: Fri, 5 Sep 2014 18:14:46 +0200
Subject: [PATCH] start/stop may hang indefinitely (like SSL init fails)

Description:
	when rerun a start/stop command, check the timeout is not hit
---
 lib389/tools.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib389/tools.py b/lib389/tools.py
index f283882..7812d12 100644
--- a/lib389/tools.py
+++ b/lib389/tools.py
@@ -212,9 +212,13 @@ class DirSrvTools(object):
                 elif line.find("Initialization Failed") >= 0:
                     # sometimes the server fails to start - try again
                     rc = os.system(fullCmd)
+                    pos = logfp.tell()
+                    break
                 elif line.find("exiting.") >= 0:
                     # possible transient condition - try again
                     rc = os.system(fullCmd)
+                    pos = logfp.tell()
+                    break
                 pos = logfp.tell()
                 line = logfp.readline()
             if line.find("PR_Bind") >= 0:
-- 
1.7.11.7

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux