[389-devel] Please review (revised): Please review: [389 Project] #47606: replica init/bulk import errors should be more verbose

[Noriko Hosoi <nhosoi@xxxxxxxxxx>]

Thank you for your comments, David and Rich!

I've separated the code from the get_next_from_buffer function and put it into a helper function _ber_get_len.  It also supports mozldap ber.

https://fedorahosted.org/389/attachment/ticket/47606/0001-Ticket-47606-replica-init-bulk-import-errors-should-.2.patch

Thanks,
--noriko

David Boreham wrote:

On 12/11/2013 7:08 PM, Noriko Hosoi wrote:

https://fedorahosted.org/389/ticket/47606

https://fedorahosted.org/389/attachment/ticket/47606/0001-Ticket-47606-replica-init-bulk-import-errors-should-.patch

Looks good to me. Pitty about the struct definition accessibility -- presumably that's an openldap-devel limitation...

The only suggestion I'd have would be to put the length extraction code in a function, in another source file, to keep connection.c slightly cleaner.


--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel