Re: [389-devel] Please review: various lib389 cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

The changes look  very good.

I have a question regarding start/stop in Replica class. Why do not you use the function self.agreement.schedule(agmdn, interval='start') and self.agreement.schedule(agmdn, interval='stop') ?

about the function 'agreement_dn(basedn, other)' why not putting it into the Agreement class ?
Note that it uses the functions 'agreements' that is Replica but I would expect it to be in Agreement class as well (renamed in 'list' ?).

Regards
thierry

On 11/21/2013 03:21 AM, Rich Megginson wrote:



--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

--
389-devel mailing list
389-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Index of Archives]     [Fedora Directory Announce]     [Fedora Users]     [Older Fedora Users Mail]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Review]     [Fedora Art]     [Fedora Music]     [Fedora Packaging]     [CentOS]     [Fedora SELinux]     [Big List of Linux Books]     [KDE Users]     [Fedora Art]     [Fedora Docs]

  Powered by Linux